Repository navigation
fix(analyzers): apply review findings across E128014, E128220, E128223, E128224, E128227 - #165
Merged
Merged
Conversation
…3, E128224, E128227 Co-Authored-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executive Summary
The 2026-11-14 union review returned 8 confirmed High findings across 5 rules. This PR fixes all of them and updates the tests, the package README, and the release files to match.
*for(a+)*; it rewrites to(?:a+)*and keeps the pattern language. The atom comparison expands character classes, so(?:/[^\s:"']+)+now fires while(?:/[^/]+)+stays silent.when-guarded discard or var arm no longer closes a union switch. The rule reports it, and the code fix stays absent becausenull when cond =>is not exhaustive.FlagBindsrouting the receiver intoLocalLinksToProcess.CompressionMode.Decompress.LoadIntoBufferAsync(long)overload caps the read. AContentLengthcheck must be null-safe, precede, and dominate the read, so a chunked response fails closed. The README remediation replaced the failing-openContentLength > Nguard. The gate also fixedHttpContentHeadersTypeNameto resolveSystem.Net.Http.Headers.HttpContentHeaders.Code Changes
5 analyzers, 2 code fixers, 7 test classes,
src/E128.Analyzers/README.md,AnalyzerReleases.Unshipped.md(E128220 Changed Rules row), and 5 lode rule-detail files. 21 files, +1276/−72.Tests and Tooling
scripts/check.sh --allgreen: shell, format, build, 2992 tests (2987 passed, 2 skipped).scripts/internal/analyzer-release-check.shclean,scripts/readme-table-diff.sh --analyzerno drift. The 6 Medium findings from the review stay unapplied as advisory.Review Guide
Rule behavior changes sit in
HandRolledProcessCaptureAnalyzer.cs(FlagBinds),ReadOnlyMemoryStreamAnalyzer.cs(IsDecompressMode),HttpBodyReadWithoutSizeBoundAnalyzer.cs(IsNullSafeBound,Dominates),UnionSwitchDiscardArmAnalyzer.cs(TryFindCatchAll), andGeneratedRegexHelpers.cs(ClassAtomOverlaps). The E128227 polarity logic is the largest rewrite; its tests pin both the fires and silent shapes.Rollback
Single commit, revert it to restore the prior detection shapes.
Links
Review plan:
plans/review-2026-11-14-general/🤖 Generated with Claude Code