Repository navigation
honour ensure_ascii for unquoted identifier keys - #124
Merged
Merged
Conversation
Owner
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dumps with ensure_ascii set (the default) is meant to produce ASCII-only output, matching the json module. String values are escaped correctly, but _encode_str returns identifier keys verbatim, so a non-ascii key such as café is written raw as {café: 1} and the output is no longer ASCII. Today the only way to get such a key escaped is quote_keys=True, which is an unrelated option.
Escape the non-ascii characters of an unquoted identifier key when ensure_ascii is set, the same way string values are already escaped. The parser accepts \u escapes inside identifiers, so the key stays unquoted and still round-trips through loads. Keeping the check in _encode_str means the identifier fast path and the quoted path now agree on ensure_ascii.