Repository navigation
Return an empty object when skipkeys drops every key - #122
Merged
dpranke merged 1 commit intoOct 14, 2026
Merged
Conversation
Owner
|
Good catch. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
skipkeys=Trueandindent=2, a mapping whose keys are all unsupported is serialized as{\n ,\n}, which cannot be parsed as JSON5.Return
{}when no keys were emitted. The regression covers numeric/string indentation, both trailing-comma settings, and an empty filtered object nested in an array.Validation on Python 3.14.6: all 81 unit tests, doctests, Ruff, Pylint, Mypy, 100% line coverage, wheel/sdist builds, and Twine checks pass. The regression fails on the unchanged implementation.
./run presubmitexits successfully, but still prints an existingpyproject.tomlformatting warning; the same warning was reproduced from the unchanged HEAD file. This PR does not alter that file.