Skip to content

fix(panel): Active VM badge, activate action, guided delete (#732) - #733

Merged
dofastted merged 2 commits into
mainfrom
cursor/fix-panel-active-vm-6b26
Oct 26, 2026
Merged

dofastted merged 2 commits into
mainfrom
cursor/fix-panel-active-vm-6b26

Conversation

@dofastted

@dofastted dofastted commented Oct 26, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes #732 by surfacing the existing vm.active / active.json state in the VM management UI and wiring delete flows to the existing activate API.

  • Active badge: table, rack, detail header, and list detail card show Active when vm.active === true.
  • Set as active: row context menu calls POST /api/panel/vms/:id/activate; ops tab button is disabled when already active.
  • Delete active slot: if other schedulable, credential-valid slots exist, the confirm dialog offers 切换活跃并删除 (auto-activate the best candidate, then DELETE). If no safe candidate, delete is disabled with guidance to switch active manually first.

Out of scope (per issue)

  • No backend auto-heal of active.json
  • No admin API fallback for unhealthy active slots
  • VERSION unchanged

Verification

  • pnpm -C web test src/features/vm/active-vm.test.ts (4 tests)
  • pnpm -C web exec tsc -b --noEmit

Operator upgrade

Node + web/dist only; no fetch:payload / wrap-cli sync required for this change alone.

Open in Web Open in Cursor 

Note

Low Risk
Frontend-only panel changes wiring to existing activate/delete APIs; delete safety is improved via client-side planning, not new server logic.

Reviewed by Cursor Bugbot for commit 7463a50. Configure here.

Show Active badge on VM list, rack, and detail views from vm.active.
Add Set as active in row menu wired to POST /vms/:id/activate.
When deleting the active slot, auto-activate a schedulable replacement
when available; otherwise block delete with guidance.

Co-authored-by: ted <kuhlmangarry24@gmail.com>
@cursor

cursor Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: ad1cab96-9386-4da7-8b4d-d4d2fc601cc1)

Co-authored-by: ted <kuhlmangarry24@gmail.com>
@cursor

cursor Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: 8bc4dcd3-3ed9-4f27-bd87-6a9522998db8)

@dofastted dofastted mentioned this pull request Oct 26, 2026
@dofastted
dofastted merged commit b8e7316 into main Oct 26, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Cannot delete revoked/disabled slot when it still holds the Active VM pointer, and UI lacks Active VM switch entry (v1.3.226)

2 participants