Repository navigation
Conversation
thinking、tool_choice、effort 与显式采样字段交给 cli-node。面板 thinking display 仍由 Node 应用,并删除写死的 panelRewrite 分支。
Contributor
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: a0711bfc-1686-457d-9ec4-c4a2793b2ce8) |
dofastted
marked this pull request as draft
October 25, 2026 21:10
Owner
Author
合并门禁这个 PR 只删除 Node 侧的模型策略,不是完整迁移。 当前线上 cli-node 还没有 配套 CLI 提交目前在本地
这些提交依赖 未重编 ELF,未部署。 |
- CHANGELOG 未发布补充 #729 cli-hop 策略下沉 cli-node 说明 - sonnet-55-policy:区分 prepareCliHopBody 透传与 prepareAnthropicRequest 策略 - mid-convo-effort:Haiku hop 不再剥离 effort,仅保留 Sonnet 5 提升行为 Co-authored-by: ted <kuhlmangarry24@gmail.com>
Owner
Author
|
关闭:核心提交(native cli-hop 不再提前改模型策略和采样字段)已随 #730 合入 main,不再单独合并。注意本 PR 描述里的门禁:cli-node native 路径接管旧模型策略需随新 ELF 部署,这一点与是否合并本 PR 无关,仍需跟进。 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prepareCliHopBody不再改 thinking 类型、tool_choice、effort,也不再删除调用方显式的 temperature、top_p、top_k、context_management。thinking_display=summarized仍由 Node 应用。panelRewrite分支。medium由 cli-node native 路径负责。该源码在本地local-src,依赖尚未推送的 cli-node 历史,未包含在这个 PR。当前线上 ELF 也未重编。Test plan
node --test test/unit/cli-hop-body.test.mjs test/unit/cache-ttl.test.mjs:42 passverify-live.py。本 PR 未部署、未合并。Note
Medium Risk
Shifts thinking, effort, and model normalization from Node to cli-node; behavior depends on matching cli-node changes and live verification before merge.
Overview
Native cli-hop stops reshaping requests in Node before they reach cli-node.
prepareCliHopBodyno longer applies model policy (applyModelRequestRules), Haiku thinking pins, unofficial high effort, or strips callertemperature/top_p/top_k/context_management. It still applies thinking display (summarized), invalid-thinking cleanup, official system/message cache markers, and related sanitization.The cli-hop path in
handle-protocoldrops the deadpanelRewritebranch (always false) that would have run unofficial persona rewrites and cache validation on the hop body;personaHideTokensis always 0 for cli-hop.Unit tests now expect model strings, thinking modes, tool choice, and sampling fields to pass through unchanged—Haiku/Opus 5.5 policy and default effort are documented as moving to cli-node (not in this PR).
Reviewed by Cursor Bugbot for commit 5e13ab2. Configure here.