Repository navigation
static: add windows/arm64 client package - #1364
Closed
fiodortretyakov wants to merge 1 commit into
Closed
fiodortretyakov wants to merge 1 commit into
fiodortretyakov wants to merge 1 commit into
Conversation
The cross-win target now also builds the CLI for windows/arm64 and packages it as build/win/arm64/docker-<version>.zip, next to the amd64 zip. The arm64 package has docker.exe only, as dockerd is not built for windows/arm64. docker/cli already builds windows/arm64 (its "cross" and "bin-image-cross" bake targets), but download.docker.com/win/static/stable/ only has x86_64, so there is no static CLI for Windows on Arm. Signed-off-by: Fiodor Tretyakov <fiodor.tretyakov@gmail.com>
Author
|
Closing this as superseded: docker-ce-packaging is deprecated in favor of docker/packaging (#1366), which already builds the windows/arm64 static packages, and download.docker.com/win/static/test/aarch64/ has 29.10.0-rc.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added a windows/arm64 client package to the
cross-wintarget: the CLI is built for windows/arm64 with the same bake target as amd64 and zipped asbuild/win/arm64/docker-<version>.zip. It holdsdocker.exeonly, since dockerd isn't built for windows/arm64.docker/cli already builds windows/arm64 (
crossandbin-image-crossin its docker-bake.hcl), but https://download.docker.com/win/static/stable/ only hasx86_64/, so a Windows on Arm machine has no native CLI to use with an engine in WSL 2 or on a remote host. winget'sDocker.DockerCLIis built from these zips, so it is x64 only as well.Publishing also needs the release pipeline to upload
build/win/arm64towin/static/stable/aarch64/, the waybuild/mac/arm64goes tomac/static/stable/aarch64/. That pipeline isn't public, so that part isn't in this PR.- How I verified it
make DOCKER_CLI_REF=v29.9.2 checkout-cli, thenmake -C static -o cross-win-engine cross-win VERSION=29.9.2, on an arm64 Linux engine.-o cross-win-engineskips the Windows engine build; dockerd.exe came from the released 29.9.2 zip. Both zips are produced, and the amd64 one has the same layout as the released zip.docker.exefrombuild/win/arm64/docker-29.9.2.zipis an ARM64 binary and runs natively on Windows 11 arm64 (Snapdragon X Elite) against Docker Engine 29.9.2 in WSL 2 over TLS:docker versionshowsOS/Arch: windows/arm64, anddocker info,docker run --rm,docker cpin both directions (files and directories, Windows paths) and bind mounts (-vand--mount) work.- Description for the changelog