Repository navigation
Conversation
Delegate local source and destination path completion to the shell, while suppressing local suggestions for container paths and extra arguments. Cover both command forms through Cobra completion requests. Related to: docker#3040 Signed-off-by: Alexandre Rodrigues <alexandre3ylf@gmail.com>
a3ylf
marked this pull request as ready for review
November 14, 2026 00:36
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #3040 (local path completion)
Related to: #2789 (legacy Fish completion)
Summary
docker cp ./anddocker cp example:/tmp/file ./disable file completion, so the shell cannot suggest local files or directories.Register a Cobra completion handler that delegates local paths to the shell. Use the existing copy-argument parser to distinguish container paths from local paths, including paths containing colons. Suppress local file suggestions for container paths, container destinations after a local source, stdin/stdout, and extra arguments. Cover both
docker cpanddocker container cpthrough completion requests.This addresses the local-path portion of #3040. Completing paths inside containers remains outside this change.
Validation on Linux:
go test -race ./cli/command/container -run '^TestCopyCompletion$'../cli/command/container/...with Go 1.27.4. Command-reference generation succeeds.The broader container-package race run fails in
TestInitTtySizeErrors; the same race reproduces with the unmodified base source. No daemon-dependent E2E tests were run.Release notes