Skip to content

Jargons: apply suggested fixes for #29 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jargons-ai wants to merge 2 commits into from
Closed

Jargons: apply suggested fixes for #29 #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0226dd5
fix: apply Jargons review suggestions to src/routes/pricing.tsx
jargons-ai[bot] Sep 27, 2026
0070dd2
fix: apply Jargons review suggestions to src/server/github-auth.ts
jargons-ai[bot] Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/routes/pricing.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ export const Route = createFileRoute('/pricing')({

// Sign in, then come back here and go straight into `target`'s checkout.
function signInThenCheckout(target: PaidPlan) {
// The `target` parameter is already validated by `isPaidPlan` in `validateSearch`
// and is one of the known `PaidPlan` IDs. This ensures it's a controlled value.
const next = `/pricing?checkout=${target}`
window.location.assign(`/auth/sign-in?next=${encodeURIComponent(next)}`)
}
Expand Down
2 changes: 1 addition & 1 deletion src/server/github-auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ export async function setSignInNext(next: unknown): Promise<void> {
}

setCookie(signInNextCookieName, path, {
maxAge: 60 * 10,
maxAge: 60,
httpOnly: true,
path: '/',
sameSite: 'lax',
Expand Down
Loading