Skip to content

Use Debian archive repositories for Bullseye builds - #314

Merged
darrenoh merged 22 commits into
mainfrom
copilot/fix-github-actions-job-failure
Oct 22, 2026
Merged

darrenoh merged 22 commits into
mainfrom
copilot/fix-github-actions-job-failure

Conversation

Copilot AI commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

PHP 7.4 builds fail because Bullseye’s security mirror returns 404 for the unzip package. Bullseye has reached end of LTS, so its packages are available from Debian’s archive.

  • Change: Configure the shared PHP base stage to use archived repositories for Bullseye and accept expired archive metadata. The downloader and PHP extension stages inherit this configuration.
    RUN if grep -q '^VERSION_CODENAME=bullseye$' /etc/os-release; then \
          sed -i 's|deb.debian.org|archive.debian.org|g' /etc/apt/sources.list \
          && echo 'Acquire::Check-Valid-Until "false";' > /etc/apt/apt.conf.d/99archive; \
        fi

Copilot AI and others added 3 commits October 22, 2026 02:52
Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>
Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>
Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job build (7.4, linux/amd64) Use Debian archive repositories for Bullseye builds Oct 22, 2026
Copilot AI requested a review from darrenoh October 22, 2026 02:57
@darrenoh
darrenoh marked this pull request as ready for review October 22, 2026 03:25
@darrenoh
darrenoh requested a balanced review from Copilot October 22, 2026 03:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The security repository is redirected to an archive suite reported missing, leaving the Bullseye package update failure unresolved.

1 open issue
What changed in this PR

This PR aims to restore Bullseye-based PHP image builds by centralizing Debian archive configuration in a shared parent stage.

Changes:

  • Redirect Bullseye package sources to Debian’s archive and disable metadata expiry checks.
  • Make downloader and PHP extension stages inherit the shared configuration.
  • Record the task checklist and completion criteria.
File Description
TODO.md Records archive migration steps and validation checklist.
base/​Dockerfile Adds Bullseye archive configuration shared by both build stages.

Review effort: Balanced

Comment thread base/Dockerfile Outdated
Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Successful PHP 7.4 package installation against the pinned security snapshot remains unverified.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Copilot AI and others added 2 commits October 22, 2026 04:35
Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>
Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Archived package availability and successful end-to-end image builds remain unverified, with CI confirmation still pending.

No open issues 🎉

Review effort: Balanced

Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Archive-source and shared dependency changes across PHP 7.4–8.5 need successful end-to-end build and functional-test results plus final human review.

No open issues 🎉

Review effort: Balanced

@darrenoh darrenoh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot You missed some paragraphs that need to be reflowed.

Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>

Copilot AI commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@copilot You missed some paragraphs that need to be reflowed.

Reflowed the remaining affected paragraphs in workflow comments, preseed cache comments, Dockerfile comments, Bake configuration, and build-test help text in 32e6eec. Wording and behavior are unchanged. Focused lint, Bake parsing, and secret checks pass. Automated code review was unavailable.

@darrenoh darrenoh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Great work so far. One question before we merge. Can you set the build action to use ARM for ARM platform builds instead of relying on QEMU on AMD?

Copilot AI and others added 2 commits October 22, 2026 17:26
Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>
Co-authored-by: darrenoh <2293701+darrenoh@users.noreply.github.com>

Copilot AI commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Great work so far. One question before we merge. Can you set the build action to use ARM for ARM platform builds instead of relying on QEMU on AMD?

Implemented in 6a90c5b: ARM64 build jobs now use native ubuntu-24.04-arm runners; AMD64 keeps ubuntu-latest. QEMU setup is skipped for native builds and retained only for cross-platform fallback. YAML lint and routing checks pass; independent review found no significant issues, and CodeQL reported no alerts. Actual ARM builds remain to be confirmed in Actions.

Copilot AI requested a review from darrenoh October 22, 2026 17:28

@darrenoh darrenoh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Why did you use ubuntu-24.04-arm? Wouldn't ubuntu-26.04-arm match ubuntu-latest that we use for AMD?

Copilot AI commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Why did you use ubuntu-24.04-arm? Wouldn't ubuntu-26.04-arm match ubuntu-latest that we use for AMD?

I chose 24.04 ARM to match the documented ubuntu-latest AMD64 image, but I missed the ongoing migration. GitHub’s announcement says the move to 26.04 runs October 19–November 19, so ubuntu-latest can currently resolve to either version. ubuntu-26.04-arm is available and would align with the new default. To guarantee matching OS releases, we should explicitly use ubuntu-26.04 for AMD64 and ubuntu-26.04-arm for ARM64 rather than mixing a moving alias with a pinned release.

Copilot AI requested a review from darrenoh October 22, 2026 18:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Shared installation and runner changes affect PHP 7.4–8.5 and both architectures, while successful end-to-end build and functional validation remains unconfirmed.

No open issues 🎉

Review effort: Balanced

@darrenoh
darrenoh merged commit 20b9e23 into main Oct 22, 2026
15 checks passed
@darrenoh
darrenoh deleted the copilot/fix-github-actions-job-failure branch October 22, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants