Repository navigation
fix: prevent Moonbeam relaunch from changing admin profile photo - #301
Merged
Merged
Conversation
Remove the user-token users.setPhoto call from redeploy and document Slack's app-icon configuration instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Remove the unused sharp dependency and rename the misleading test.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Prevents Moonbeam relaunches from overwriting the installing admin’s Slack profile photo.
Changes:
- Removes Slack profile-photo upload logic and related tests.
- Updates Slack scopes and icon configuration documentation.
- Preserves deployment images, quotes, and changelog announcements.
| File | Summary | Review note |
|---|---|---|
README.md |
Updates Slack setup and token documentation. | No additional comments. |
packages/backend/src/shared/services/web/web.service.ts |
Removes profile-photo upload support. | No additional comments. |
packages/backend/src/shared/services/web/web.service.spec.ts |
Removes profile-photo tests and mocks. | No additional comments. |
packages/backend/src/ai/ai.service.ts |
Stops photo updates during redeploys. | Nit (4 votes): Remove the unused sharp dependency and refresh the lockfile. |
packages/backend/src/ai/ai.service.spec.ts |
Updates redeploy test setup and assertions. | Nit (1 vote): Rename the test to match its remaining coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: sfreeman422 <16405652+sfreeman422@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
users.setPhotoand the unused WebService photo-upload method. That endpoint acts on the account represented byMUZZLE_BOT_USER_TOKEN, which was changing the authorizing admin's personal photo.users.profile:writescope and explain that Moonbeam's app/bot icon must be configured in Slack rather than updated by this relaunch flow.Validation