Skip to content

fix: prevent Moonbeam relaunch from changing admin profile photo - #301

Merged
sfreeman422 merged 2 commits into
masterfrom
fix/moonbeam-profile-photo-token
Oct 6, 2026
Merged

sfreeman422 merged 2 commits into
masterfrom
fix/moonbeam-profile-photo-token

Conversation

@sfreeman422

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the redeploy call to users.setPhoto and the unused WebService photo-upload method. That endpoint acts on the account represented by MUZZLE_BOT_USER_TOKEN, which was changing the authorizing admin's personal photo.
  • Preserve the generated deployment image, quote, and changelog announcement.
  • Update Slack setup documentation to remove the unneeded users.profile:write scope and explain that Moonbeam's app/bot icon must be configured in Slack rather than updated by this relaunch flow.

Validation

  • 69 targeted backend tests passed.
  • Backend TypeScript build passed.
  • Pre-commit ESLint and Prettier checks passed.
  • Backend and frontend coverage gates passed (736 backend tests and 116 frontend tests).

Remove the user-token users.setPhoto call from redeploy and document Slack's app-icon configuration instead.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings October 6, 2026 16:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Remove the unused sharp dependency and rename the misleading test.

Review effort: Lite
Findings: 1 Low severity

Open (1)
What changed in this PR

Prevents Moonbeam relaunches from overwriting the installing admin’s Slack profile photo.

Changes:

  • Removes Slack profile-photo upload logic and related tests.
  • Updates Slack scopes and icon configuration documentation.
  • Preserves deployment images, quotes, and changelog announcements.
File Summary Review note
README.md Updates Slack setup and token documentation. No additional comments.
packages/​backend/​src/​shared/​services/​web/​web.service.ts Removes profile-photo upload support. No additional comments.
packages/​backend/​src/​shared/​services/​web/​web.service.spec.ts Removes profile-photo tests and mocks. No additional comments.
packages/​backend/​src/​ai/​ai.service.ts Stops photo updates during redeploys. Nit (4 votes): Remove the unused sharp dependency and refresh the lockfile.
packages/​backend/​src/​ai/​ai.service.spec.ts Updates redeploy test setup and assertions. Nit (1 vote): Rename the test to match its remaining coverage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread packages/backend/src/ai/ai.service.ts Resolved
Co-authored-by: sfreeman422 <16405652+sfreeman422@users.noreply.github.com>
@sfreeman422
sfreeman422 merged commit 7a4a7af into master Oct 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants