Repository navigation
Revert "Vuln Remediation" - #300
Merged
Merged
Conversation
This reverts commit 093310d.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical dependency vulnerabilities, an invalid PNG fixture, and removed runtime verification must be addressed.
Review effort: Lite
Findings: 3
Open (4)
What changed in this PR
Reverts the dependency, Docker, CI, and test-fixture changes from PR #299.
Changes:
- Downgrades backend/frontend dependencies and updates the lockfile.
- Restores the previous Docker and CI configuration.
- Restores coverage checks and changes the PNG test fixture.
| File | Summary |
|---|---|
packages/frontend/package.json |
Restores older Vitest versions. |
packages/backend/src/ai/ai.service.spec.ts |
Changes the PNG fixture; the replacement has an invalid CRC. |
packages/backend/package.json |
Restores vulnerable express, sharp, and TypeORM versions. |
packages/backend/Dockerfile |
Restores the previous runtime layout. |
package-lock.json |
Regenerates dependency resolutions, including vulnerable versions. |
.husky/pre-commit |
Restores coverage checks. |
.github/workflows/ci.yml |
Removes the Docker runtime smoke test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "decimal.js": "^10.6.0", | ||
| "easy-table": "^1.1.1", | ||
| "express": "^4.22.3", | ||
| "express": "^4.18.2", |
| "sharp": "^0.35.5", | ||
| "typeorm": "^0.3.31", | ||
| "uuid": "^11.1.1", | ||
| "sharp": "^0.34.5", |
| "typeorm": "^0.3.31", | ||
| "uuid": "^11.1.1", | ||
| "sharp": "^0.34.5", | ||
| "typeorm": "^0.3.22", |
| it('publishes deployment message with quote, changelog, and profile photo update', async () => { | ||
| const validPngBuffer = Buffer.from( | ||
| 'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAACXBIWXMAAAPoAAAD6AG1e1JrAAAADUlEQVQImWNgYGBgAAAABQABh6FO1AAAAABJRU5ErkJggg==', | ||
| 'iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+aF9kAAAAASUVORK5CYII=', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Reverts #299