Repository navigation
Revert "Remediate Open Vulns" - #298
Merged
Merged
Conversation
This reverts commit 05947d7.
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
It reopens security vulnerabilities and includes invalid test data and costly pre-commit checks.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Reverts the dependency, workflow, and test-fixture changes from PR #297.
Changes:
- Restores older backend and frontend dependency versions.
- Regenerates the lockfile.
- Restores the prior PNG fixture.
- Re-enables full pre-commit coverage and adjusts CI dependency archiving.
| File | Summary | Review |
|---|---|---|
packages/frontend/package.json |
Restores previous Vitest versions. | — |
packages/backend/src/ai/ai.service.spec.ts |
Restores the prior PNG fixture. | Moderate, 1 vote: fixture has invalid CRC and does not exercise the success path. |
packages/backend/package.json |
Restores older backend dependencies. | Critical, 2 votes: reopens vulnerabilities addressed by PR #297. |
package-lock.json |
Regenerates the reverted dependency graph. | — |
.husky/pre-commit |
Re-enables full workspace coverage checks. | Moderate, 1 vote: duplicates CI and may make commits slow or failure-prone. |
.github/workflows/ci.yml |
Adjusts dependency archiving. | — |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "decimal.js": "^10.6.0", | ||
| "easy-table": "^1.1.1", | ||
| "express": "^4.22.3", | ||
| "express": "^4.18.2", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reverts #297