Skip to content

Revert "Remediate Open Vulns" - #298

Merged
sfreeman422 merged 1 commit into
masterfrom
revert-297-vuln-fix
Oct 1, 2026
Merged

sfreeman422 merged 1 commit into
masterfrom
revert-297-vuln-fix

Conversation

@sfreeman422

Copy link
Copy Markdown
Collaborator

Reverts #297

Copilot AI lite review requested due to automatic review settings October 1, 2026 00:56
@sfreeman422
sfreeman422 merged commit 1dcbb51 into master Oct 1, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

It reopens security vulnerabilities and includes invalid test data and costly pre-commit checks.

Review effort: Lite
Findings: 1 High severity

Open (1)
What changed in this PR

Reverts the dependency, workflow, and test-fixture changes from PR #297.

Changes:

  • Restores older backend and frontend dependency versions.
  • Regenerates the lockfile.
  • Restores the prior PNG fixture.
  • Re-enables full pre-commit coverage and adjusts CI dependency archiving.
File Summary Review
packages/​frontend/​package.json Restores previous Vitest versions. —
packages/​backend/​src/​ai/​ai.service.spec.ts Restores the prior PNG fixture. Moderate, 1 vote: fixture has invalid CRC and does not exercise the success path.
packages/​backend/​package.json Restores older backend dependencies. Critical, 2 votes: reopens vulnerabilities addressed by PR #297.
package-lock.json Regenerates the reverted dependency graph. —
.husky/​pre-commit Re-enables full workspace coverage checks. Moderate, 1 vote: duplicates CI and may make commits slow or failure-prone.
.github/​workflows/​ci.yml Adjusts dependency archiving. —

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

"decimal.js": "^10.6.0",
"easy-table": "^1.1.1",
"express": "^4.22.3",
"express": "^4.18.2",
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants