Repository navigation
fix(commands): more command steps use the shared input checks - #783
Merged
Merged
Conversation
…lders with the shared checks plan-files.cjs claim now also makes the run folder of /code-review, /bug-analysis and /research, and the design folder of /plan, with the same folder checks as the plan run folder. check also accepts a new design file. The plan folder alone keeps its tracking rule.
/code-review, /bug-analysis and /research make their run folder with plan-files.cjs claim, and /plan checks its design file path with the same script. /plan and /research make the topic slug in prose and check its pattern; the docs-framework skill drops the shell form of the slug. /bug-analysis and /resolve fetch the PR body only for a PR number of digits only. A new guard pins each step.
Each changed build is set to its measured size with no headroom. The CHANGELOG entry and the PR list each row with the old and new value.
…heckout /bug-analysis sets the report date from the claimed folder. /plan runs the design check in the checkout, stops on a quote anywhere in the artifact path, and takes seconds in the stamp once when a file stands at the path. The plan name example stays, as a test pins it.
Owner
Author
Evidence (head 67a631f)Merge of main (67a631f): origin/main (dcbd9f0) merged with no conflict. CI on 67a631f: build-and-test (22), macos-bash32-hooks and security/snyk pass. The local suite below ran on 0c47242, the head before the merge. Tests (local, node 24)
CI (0c47242): build-and-test (22), macos-bash32-hooks and security/snyk pass. RED first
Changes since the first evidence (e348dd6)
Independent review (one agent, the diff of the three steps only)
Static scan: Snyk Code on |
The Git agent passes PR_NUMBER to gh pr view or to a --pr flag only when it is digits only, in post-review-summary, post-resolution-summary, check-merge-readiness and update-pr-evidence. Outside a git checkout, claim reviews|bug-analysis|research takes the working folder as its root with the same folder checks, so /research still works there.
…table The comment operations report a skip for a PR number that is not digits only, in fewer bytes. update-pr-evidence gates the PR number at the start of its step and keeps its evidence-path sentence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
More command steps use the shared input checks that
plan-files.cjsadded in #776./code-review,/bug-analysisand/researchmake their run folder withplan-files.cjs claim, not withmkdir -p. Only the script'sRUN_DIR=line withexit=0sets the folder. Any other result stops the step./planPhase 14 runsplan-files.cjs claim designandcheckon the design file path before it makes the file.plan-files.cjsgets the new formsclaim reviews|bug-analysis <branch-slug>,claim research <topic-slug>andclaim design.checkalso accepts a new design file. Plainclaim(the plan run folder) does not change. Only the plan folder keeps its tracking rule, so a team that commits reviews, research or design files keeps working./planand/researchmake the topic slug in prose and use it only when it matches^[a-z0-9-]{1,50}$, elseuntitled. The docs-framework skill and its patterns reference have no shell form of the slug now./bug-analysisand/resolvefetch the PR body only when the PR number is digits only, as/code-reviewdoes.PR_NUMBERtogh pr viewor to a--prflag only when it is digits only: post-review-summary, post-resolution-summary, check-merge-readiness (its script call and its evidence step) and update-pr-evidence. The review-decision step of check-merge-readiness is the script's specification and runs only inside the script, so its text does not change; a frozen golden pins it.claim reviews|bug-analysis|researchtakes the working folder as its root, with the same folder checks./researchtherefore still works outside a git repository. The plan and design claims still need a checkout.Closes #781
Tests
tests/evidence-policy/plan-files.test.ts: 41 new cases for the newclaimforms and the designcheck. They failed before the script change.tests/guards/shared-input-checks.test.ts(new): one arm per step, each with known-bad probes. The first 14 cases failed on the old prompts; the 5 Git-agent cases failed before the_pr.mdschange.pass-paths,docs-framework-authority,docs-root,code-review-diff-gating,bug-analysis/structural,resolve/known-limits,retired-wording.docs-root: the docs-path mention floor falls from 42 to 36. Six literal run-folder paths left the corpus, because the claim now names those folders. The new guard pins each claim.Size ceilings (
tests/fixtures/numeric-floors.json)Each row is set to the measured size, with no headroom.
mkdir -p; only itsRUN_DIRline setsREVIEW_DIRandTIMESTAMP.mkdir -p; the PR body fetch takes the digits-only gate; the report date takes the stamp of the folder.Known limits
/code-review,/bug-analysisand/researchnow stop when the checkout path holds a quote,$, a backtick,\, a glob character or a control character./planalready had this rule.Known follow-ups
src/assets/skills/review-methodology/references/patterns.md:99-105still showsmkdir -pfor a reviews path. No command runs it before the claim.^[a-z0-9-]{1,50}$also accepts a leading or trailing dash. The script then refuses the design name, so the step stops.src/assets/skills/docs-framework/references/violations.mdkeeps wrong/right bash examples that set a raw title in a variable. They are examples, not a slug command.