Repository navigation
feat(agents): deny six unused tools for Harden, Polish and Research - #779
Merged
Merged
Conversation
Harden, Polish and Research start with six tools that none of their paths use. Each start uses tokens for these tools. They now deny Monitor, TaskStop, Workflow, Artifact, ListAgents and ReportFindings, as Code, Fix and Refactor do. - The six names join SHARED_DENYLIST (17 to 23 names). The Code-only extra list is gone. Code, Fix, Refactor and Research deny exactly the list. Harden and Polish add Skill and mcp__*. - The guard loops over every deny-list row and every shared name for the row, body and pin probes. A new check reports an allowlist agent that grants any shared deny name, with its own known-bad probe. - Five size ceilings rise by 85 bytes each: frontmatter deny lines only, no body text. research 5133 to 5218, research (curation off) 4773 to 4858, harden 4806 to 4891, harden (curation off) 4238 to 4323, polish 4495 to 4580. The size guard header states the either-way rule. Task: feat/778-worker-agents-deny-unused-tools Refs #778
The agent design doc and the Unreleased changelog bullet now cover all six agents that deny Monitor, TaskStop, Workflow, Artifact, ListAgents and ReportFindings: Code, Fix, Refactor, Research, Harden and Polish. Each gives its reason. The headless figure stays scoped to a Code start. The ceiling sentence adds the five Research, Harden and Polish rows, +85 bytes each. Task: feat/778-worker-agents-deny-unused-tools Refs #778
Owner
Author
Review and test evidence (head e94a919)Implement gates (at 99cdbbf)Gate level lean. Polish: skipped (lean). Self-review: one fix (a reason sentence, 99cdbbf). Alignment: 7 of 7 criteria met. Code review (cycle 1, at 5a8d1ef)Gate level lean: security, testing and reliability. Result: approved with comments. 0 critical, 0 high, 2 medium, 4 suggestions. Security found no issues.
Resolution (at e94a919)Fixed 5, deferred 1, false positive 0, escalated 0.
Evidence
Merge readiness: waits for an approving review. CI is clear. No review threads are open. |
The allowlist check now compares the name before the first parenthesis, so a scoped entry such as Agent(x) is reported like the bare name. The known-bad probe seeds both forms for every shared name. The test that pinned the line order of the six added names is gone, with its constant. A new deny row still joins every loop; the deny-set pin names the rows. Refs #778
The six agents start no background run. A spawned subagent whose foreground call passes its timeout is re-invoked by the end notice, so none needs Monitor. The old text said they run every command in the foreground, which does not hold for Harden. Refs #778
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden, Polish and Research never use six tools: Monitor, TaskStop, Workflow, Artifact, ListAgents and ReportFindings. Each agent start pays tokens for every tool in its list. This change adds the six names to the
disallowedToolslist of these three agents. Code, Fix and Refactor already have them (#775).Changes
tools:list grants any name on the shared deny list.Token Effect
Testing
Known Limits
Breaking Changes
None expected.
Related Issues
Closes #778