Repository navigation
fix(pydantic-ai-daytona): allow daytona SDK <1 - #102
Merged
Merged
Conversation
The single-minor pin (daytona>=0.203.0,<0.204.0) could not be installed alongside other Daytona SDK users such as pydantic-ai-harness[daytona] (daytona>=0.223.1,<1) and locked users out of every later SDK release. Keep the verified floor and allow any SDK below 1.0. Signed-off-by: Mislav Ivanda <mislavivanda454@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
pydantic-ai-daytonapinned the Daytona SDK to a single minor version (daytona>=0.203.0,<0.204.0). For a library that has to run next to other Daytona-dependent packages, that pin is too narrow:pydantic-ai-harness[daytona], which requiresdaytona>=0.223.1,<1.What changes
daytona>=0.203.0,<0.204.0→daytona>=0.203.0,<1<1keeps a future 1.0 (where breaking changes are expected) from installing untested. It has the same shape aspydantic-ai-harness's own pin, so the two ranges overlap.Verification
With the new range, against the latest SDK (
daytona0.226.1) installed alongsidepydantic-ai-harness[daytona]0.62.0 andpydantic-ai-slim2.62.0:pip check: no broken requirementsruffandmypy: cleanTrade-off
Before 1.0, a minor SDK release can still change an API. With a wider range, such a break would reach users before this package's CI notices, because CI only runs when the package changes. A scheduled live run would close that gap; it isn't part of this PR.
Summary by cubic
Widens the
daytonaSDK range inpydantic-ai-daytonafrom>=0.203.0,<0.204.0to>=0.203.0,<1so the package can be installed alongsidepydantic-ai-harness[daytona]and pick up later SDK fixes.<1excludes a future 1.0, where breaking changes are expected, and matchespydantic-ai-harness's own range shape.pip check,ruff,mypy, 165 unit tests, and 21 live sandbox tests.Trade-off
Before 1.0, a minor SDK release can still change an API, and CI only runs when this package changes, so such a break could reach users before this package's CI notices.
Written for commit 75e1dce. Summary will update on new commits.