Repository navigation
Improve editor space, look browsing and tool states - #159
Merged
Merged
Conversation
dancancer
marked this pull request as ready for review
October 30, 2026 14:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrow editor windows now preserve more room for the photo, and all four clients provide look categories, name search, Recent and an import action outside the horizontal list. Filtering does not change the applied look; Recent updates only after a successful save.
docs/design/editor-workspace/. The cross-PR record is archived; phase checklists remain available in Git history.Source:
b72307974f05c3929857632f7c34e358ea5a483d.Base:
development@9857b4794bfa4ba26559b39fd99c67a27c4d88d7, including batch-flow PR #158 and X3F PR #157.Runtime checks used the code at
953cbee2; the final commit changes documentation only. Compiled source manifests and installed binary hashes were checked.The broader M3 viewport checks were completed before the X3F rebase at
0494eb48: Mac minimum-width German layout, histogram/manual sizing, recipe preset followed by two distinct DNG exports; iPhone/iPad rotation and original-DNG recipe/lens controls; Android 320/412dp and landscape. The affected integration flows above were then rerun with the new native engine. Independent code and visual reviews found no remaining M3 defect.A native Mac collection with 122 DNG paths retained responsive selection and scrolling. This is an interaction observation, not a decoder/export throughput benchmark. Default user profiles and original photos were preserved.
On 2026-10-30 the user explicitly moved iPad split view, Android multiwindow, Windows 100%/150% DPI and complete VoiceOver/TalkBack/Narrator workflows to release acceptance. Default-font, narrow-window, orientation, keyboard, native accessibility-state and combined-flow coverage remains in this iteration. Physical HDR brightness, hardware GPU and real-device haptics are not demonstrated by simulator/VM runs.
An inherited PR #157 limitation remains separate from this change: Android/Windows legacy-X3F edits with enabled lens correction do not clear those flags when switching to normal rendering, so native admission can reject that state. This PR preserves that existing mode migration behavior.
Hosted CI #357 passed all seven jobs: contracts, four-platform models, platform selection and aggregate result. Its checkout log confirms merge candidate
a14f20d1combining sourceb7230797with base9857b479. Local UI execution is not presented as hosted CI; logs, source/binary receipts and screenshots are retained outside tracked source. No rendering algorithm, C ABI or photo/preset/look storage format changes are included in this PR.Merged into
developmentasdb6e125af545b7cdf679148136b2974c6f1c3613. Post-merge CI #358 passed all seven jobs at that exact commit. Remote ancestry and identical source/merge trees were verified. Owned test runtimes, simulator data, generated builds and copied fixtures were cleaned up; compact evidence was retained.