Repository navigation
Read HostService as its end state - #83
Merged
Merged
Conversation
czpython
force-pushed
the
claude/friendly-easley-72cbb3
branch
from
October 22, 2026 14:37
7120e24 to
cb0bb2a
Compare
czpython
force-pushed
the
claude/issuer-refusal-422-08395b
branch
from
October 22, 2026 14:50
ce9fd52 to
6435813
Compare
czpython
force-pushed
the
claude/friendly-easley-72cbb3
branch
from
October 22, 2026 14:54
cb0bb2a to
b5f9800
Compare
The template lookup lives in create_host, its one caller. The idempotency lookup is one positive branch. Comments that narrated the code, the caller or a provider are gone; the ones that stay say why.
czpython
changed the base branch from
claude/issuer-refusal-422-08395b
to
main
October 22, 2026 14:56
czpython
force-pushed
the
claude/friendly-easley-72cbb3
branch
from
October 22, 2026 14:56
b5f9800 to
4ab62a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A checklist pass over
hosts/service.py, on main after #80.create_host, its one caller, and reads the row by id._lookup_idempotency_keyis one positive branch; the miss falls through. Its caller reads the key in one positive condition too.create_hostnames the host and picks the image in the row itself, and raises the storedlast_errorwithout a fallback.from Noneoutside anyexceptis gone.provisiontakes the host row it already has; the string id, its parse and the lookup are gone.scan_known_hostsraisesHostKeyScanError, a plain exception beside the other hosts errors, andprovisioncatches that type.scan_known_hosts, its one caller, and the failure detail is built only when it fails.The lease intent (
expires_atand its...sentinel) is untouched; it has its own change.