Repository navigation
Pass the permanent opt-in by name through HostService - #82
Merged
Merged
Conversation
czpython
force-pushed
the
claude/jovial-brahmagupta-64b7be
branch
from
October 22, 2026 14:40
9a60fd1 to
94309e2
Compare
The route reads the wire once: an explicit null becomes permanent=True, and expires_at carries the caller's instant or None for the default lease. The service stamps the lease where it did before, without an ellipsis sentinel or an isinstance check. The touched tests read as the end state: truthiness asserts, pytest.raises, and comments trimmed to the why.
czpython
force-pushed
the
claude/jovial-brahmagupta-64b7be
branch
from
October 22, 2026 15:09
94309e2 to
3dae614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /hostsis the only place that reads the wire. An explicitexpires_at: nullbecomespermanent=True;expires_atcarries the caller's instant, orNonefor the default lease.HostService.get_or_create_host,create_hostand_try_claim_pool_hosttake both by name. The lease is still stamped where it was: on the pool claim, replacing the warm-pool TTL, and after provisioning, replacing the safety TTL.VMProvider.lease_endstill caps it. The...sentinel, theEllipsisTypeunion and theisinstancechecks are gone.The wire contract is unchanged: omitted means the default lease, null means a permanent host.
The touched tests read as the end state: truthiness asserts,
pytest.raises, and comments trimmed to the why.