Repository navigation
Fail the host on any provider error in provisioning - #77
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M34UnuQrWKXnCqmUXDQf58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Paulo · project thread
Before:
HostService.provisioncaught onlyProviderCommandErrorandProviderTransportErrorfromcreate_vm. Cloudflare, Daytona, E2B and Vercel each wrappedcreate_vmin a try block that turned auth and not-found errors intoProviderCommandError; a provider that missed one gave a 500.After: provisioning catches
ProviderError, so any provider error marks the hosterrorwith its real type inlast_error(for exampleProviderAuthError: ...). The four try blocks are gone.How: one
except ProviderErrorinprovision. The delete path still treatsProviderNotFoundErroras done. The Cloudflare 401 test now expectsProviderAuthError, and one HostService test covers an auth error fromcreate_vm. Also lifts function-level imports intest_models.pyto the top.Verified:
pytest(845 passed; the 2test_environment_pamfailures also fail on main in this container),ruff check,ruff format --check,pyright.Generated by Claude Code