Repository navigation
PIM-9561 Add external db parameters to init_master and init_application_server SDK methods - #375
Open
alekoz-ctera wants to merge 2 commits into
Open
alekoz-ctera wants to merge 2 commits into
alekoz-ctera wants to merge 2 commits into
Conversation
…on_server SDK methods
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
Reviewed by Cursor Bugbot for commit 751cf5e. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes the portal setup API and sends DB passwords and TLS material in init payloads, but defaults preserve embedded mode and validation blocks weak or inconsistent external configs.
Overview
Adds Enterprise DB support to master and application-server setup: callers can pass keyword-only
database_mode='external'plus connection, auth, and TLS settings onSetup.init_masterandSetup.init_application_server. Default behavior stays embedded PostgreSQL; external fields are rejected unless mode is external.A new
external_database.pymodule validates inputs (required host/user, credentials vs certificate auth, SSL modes with CA when verifying), loads PEM certs/keys from paths or inline strings, and buildsExternalDatabaseConfigonInitServerParams(databaseMode,externalDatabaseConfig). Token auth is enumerated but explicitly rejected until the portal supports it;disableSSL is not allowed.Documentation examples and unit tests cover validation, cert bundles, and that setup multipart payloads include the external config for master and slave init.
Reviewed by Cursor Bugbot for commit d97ade0. Bugbot is set up for automated code reviews on this repo. Configure here.