Skip to content

ci: run e2e tests per engine in a matrix and clean up test scripts #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fernandezcuesta wants to merge 9 commits into from
Open

ci: run e2e tests per engine in a matrix and clean up test scripts #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d6f3f67
chore: bump up runners and decouple CI from go version
fernandezcuesta Sep 8, 2026
3f35eda
fix: infer go version
fernandezcuesta Sep 22, 2026
49c1efe
Merge branch 'master' into chore/ci-improvements
fernandezcuesta Sep 30, 2026
29a4c7a
ci: allow (re)running test for a specific DB engine
fernandezcuesta Sep 30, 2026
add4010
Merge branch 'master' into chore/ci-improvements
fernandezcuesta Oct 8, 2026
a035745
ci: run e2e tests per engine in a matrix and clean up test scripts
fernandezcuesta Oct 8, 2026
17b04e8
test: generate MariaDB TLS certs in a temp dir
fernandezcuesta Oct 8, 2026
85caa71
Merge remote-tracking branch 'origin/chore/ci-improvements' into chor…
fernandezcuesta Oct 28, 2026
f60fd39
fix: mssql server cleanup missing PVC delete
fernandezcuesta Oct 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ on:
type: string

env:
# Common versions
DOCKER_BUILDX_VERSION: 'v0.23.0'

# Common users. We can't run a step 'if secrets.AWS_USR != ""' but we can run
Expand Down Expand Up @@ -197,6 +196,10 @@ jobs:
runs-on: ubuntu-26.04
needs: detect-noop
if: needs.detect-noop.outputs.noop != 'true'
strategy:
fail-fast: false
matrix:
engine: [mysql, postgresql, mssql]

steps:
- name: Setup QEMU
Expand Down Expand Up @@ -251,7 +254,7 @@ jobs:
# BUILD_ARGS: "--load"

- name: Run E2E Tests
run: make e2e USE_HELM=true POSTGRES_VERSION=${{ inputs.postgres_version || '18' }}
run: make e2e USE_HELM=true ENGINE=${{ matrix.engine }} POSTGRES_VERSION=${{ inputs.postgres_version || '18' }}

publish-artifacts:
runs-on: ubuntu-26.04
Expand Down
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ e2e.run: test-integration
CROSSPLANE_HELM_CHANNEL ?= stable
CROSSPLANE_HELM_CHART_VERSION ?=
POSTGRES_VERSION ?= 18
# DB selects the integration test suite: all, mysql, postgresql or mssql.
DB ?= all
# ENGINE selects the integration test suite: all, mysql, postgresql or mssql.
ENGINE ?= all
# skipcleanup=true keeps the kind cluster and provider after the run; the next run reuses them.
skipcleanup ?= false

Expand All @@ -99,7 +99,7 @@ test-integration: $(KIND) $(KUBECTL) $(CROSSPLANE_CLI) $(HELM)
CROSSPLANE_HELM_CHANNEL=${CROSSPLANE_HELM_CHANNEL} \
CROSSPLANE_HELM_CHART_VERSION=${CROSSPLANE_HELM_CHART_VERSION} \
POSTGRES_VERSION=${POSTGRES_VERSION} \
DB=${DB} \
ENGINE=${ENGINE} \
skipcleanup=${skipcleanup} \
$(ROOT_DIR)/cluster/local/integration_tests.sh || $(FAIL)
@$(OK) integration tests passed
Expand Down
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,11 @@ make build
make e2e # or: make test-integration
```

Options (pass as `make` variables, e.g. `make e2e DB=postgresql`):
Options (pass as `make` variables, e.g. `make e2e ENGINE=postgresql`):

| Variable | Default | Description |
|---|---|---|
| `DB` | `all` | Database suite to run: `all`, `mysql`, `postgresql` or `mssql`. |
| `ENGINE` | `all` | Database engine suite to run: `all`, `mysql`, `postgresql` or `mssql`. |
| `skipcleanup` | `false` | `true` keeps the kind cluster and the provider after the run. The next run reuses the cluster (skips cluster and Crossplane setup) and redeploys the provider. |
| `QUICK_TEST` | unset | `true` stops after the provider is healthy, without running database tests. |
| `POSTGRES_VERSION` | `18` | PostgreSQL server image version. |
Expand Down
1 change: 1 addition & 0 deletions cluster/local/.shellcheckrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
external-sources=true
Loading