Repository navigation
feat: add watch for user/role secret - #470
Open
fernandezcuesta wants to merge 4 commits into
Open
fernandezcuesta wants to merge 4 commits into
fernandezcuesta wants to merge 4 commits into
Conversation
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
marked this pull request as ready for review
September 30, 2026 22:53
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add a watcher to the secret which Users/Roles use in the BYOP use-case, so we don't have to wait till the next reconcile loop (poll-interval, default 10m) for the change to be applied.
Fixes #469
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Unit tests added.