Skip to content

chore(renovate): track Go toolchain version in CI and Dockerfile - #162

Merged
stevendborrelli merged 1 commit into
crossplane-contrib:mainfrom
stevendborrelli:renovate-go-version
Oct 26, 2026
Merged

stevendborrelli merged 1 commit into
crossplane-contrib:mainfrom
stevendborrelli:renovate-go-version

Conversation

@stevendborrelli

Copy link
Copy Markdown
Member

Description of your changes

GO_VERSION: '1.26' in CI picks up whatever patch golang:1.26 points to when the build runs, and nothing records or checks that version. As a result, v0.7.0 shipped built with go1.26.6, which is missing the crypto/x509 fix for GO-2026-6809 (see #158).

This PR:

  • Pins GO_VERSION in .github/workflows/ci.yml to 1.26.10.
  • Changes the Dockerfile ARG GO_VERSION default from 1 to 1.26.10, so a local docker build uses the same toolchain as CI.
  • Adds two Renovate customManagers (regex, golang-version datasource) that track both of these values.
  • Groups all golang-version updates under one "Go" group, so CI and the Dockerfile are updated in the same PR.

Renovate still detects the go directive in go.mod but doesn't bump it, so the module's minimum Go version is unchanged.

Tests

  • renovate-config-validator renovate.json: Config validated successfully.
  • renovate --platform=local --dry-run=lookup: Renovate extracts go 1.26.10 from both ci.yml and Dockerfile and offers an update to 1.27.3.

I have:

🤖 Generated with Claude Code

GO_VERSION in ci.yml floated on '1.26', so the patch level of the Go
toolchain used for release builds was whatever golang:1.26 resolved to
at build time (v0.7.0 shipped with go1.26.6, missing a crypto/x509 CVE
fix). Pin GO_VERSION and the Dockerfile ARG default to 1.26.10 and add
Renovate regex managers using the golang-version datasource so Go
updates arrive as grouped PRs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Steven Borrelli <steve@borrelli.org>
@stevendborrelli
stevendborrelli merged commit f075253 into crossplane-contrib:main Oct 26, 2026
6 checks passed
@stevendborrelli
stevendborrelli deleted the renovate-go-version branch October 26, 2026 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant