Repository navigation
Benchmark fork PRs: complete the checkout opt-in - #388
Merged
Merged
Conversation
Naming the head repository was not enough: the checkout guard demands its literal allow-unsafe-pr-checkout flag before fetching fork code under pull_request_target. The approval story is unchanged -- the gate pins the head SHA at label time, the benchmark label is the maintainer's consent to run that code on the dedicated machines, no credentials persist, and tooling comes from the trusted base commit.
Benchmark report
Run & raw JSON artifacts · flag rule: |median Δ| > max(2%, 3×CV of the noisier side) · advisory only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #387: after it merged, re-labeling #386 still failed —
Naming the head repository (#387) is not accepted as the opt-in; the guard requires its literal flag. This sets
allow-unsafe-pr-checkout: trueon the Checkout head step only.Why this stays governed: adding the
benchmarklabel requires triage access, the gate honors only the labeling event itself and pins the head SHA at that moment (later pushes cannot ride the approval), the label is stripped after each run,persist-credentials: false, and comparison tooling always comes from the trusted base commit. The operative trust statement: anyone with triage access can authorize a reviewed PR's code to run on the dedicated machines — label after reading the diff.