Repository navigation
Canvas App: pin the vendored build; take canvas-app c425198 - #5
Open
collinrijock wants to merge 2 commits into
Open
collinrijock wants to merge 2 commits into
collinrijock wants to merge 2 commits into
Conversation
crates/copper-cloud/assets/CANVAS_APP_REF names the canvas-app commit whose dist/web/index.html is vendored as canvas-app.html (62228f5, what 0.11.1 ships). packaging/sync-canvas-app.sh now works from the pin, as Copper's Canvas/sync.sh does: no argument re-fetches the pinned build, REF pins a new commit and fetches it, --check compares the vendored file with the pinned build, --from vendors a local one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ngs, invites, account menu) Vendors canvas-app main's web build. Served by copper-cloud (not canvas-cloud) the new sign-in paths stay out of the way: the page's GET /v1/info goes without the gate header, gets 401 instance_key, and the app treats the origin as a plain static server, so there are no single sign-on buttons and the sign-in form keeps its server / link-code field. Signed in with a link code, invites list through the canvas link's /v1/invites proxy. copper-browser/canvas-app@62228f5...c425198 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the vendored Canvas App (
/canvas/) to a canvas-app commit and takes canvas-app main.crates/copper-cloud/assets/CANVAS_APP_REFnames the canvas-app commit whosedist/web/index.htmlis vendored ascrates/copper-cloud/assets/canvas-app.html.packaging/sync-canvas-app.shnow works from it, like Copper'sCanvas/sync.sh: no argument re-fetches the pinned build;REFpins a new commit and fetches it;--checkcompares the vendored file with the pinned build;--from FILEvendors a local build. The first commit pins62228f5, which is what 0.11.1 ships (its file is byte-identical), so it changes no bytes.c425198(main). This brings in Continue with Google, link landings (#/join/…,#/c/…signed out),?focus=, invites and the account menu (compare).How it behaves when copper-cloud serves it (not canvas-cloud)
I checked this against a local copper-cloud built from this branch.
GET /v1/infogoes out without the gate header. It gets401 {"error":"instance_key"}, so the app treats the origin as a plain static server. There are no SSO buttons and nothing calls/v1/auth/oidc/…, and the sign-in form keeps its Server / link code field, as in 0.11.1./canvas/#/join/<token>) now opens a "You've been invited to a canvas" card with that form, where it used to show a toast. The console shows no errors.GET /v1/invitesgoes through the canvas link's existing/v1/invitesproxy. If that fails, the app only hides the invites list.*.exowatt.comhosts, such as dev1, the app shows the Exowatt brand on its own screens (not on the board).Tests
cargo test -p copper-cloud --locked --test canvas_apppasses.packaging/sync-canvas-app.sh --checkreportscanvas-app.html matches canvas-app c425198d038b….The hourly sync workflow is stacked on top of this PR (next PR). Not merging; releases and dev1 deploys are Felipe's.
🤖 Generated with Claude Code