Repository navigation
fix(import): cooklang-import 0.12.0, off the models OpenAI removes on 2027-01-14 - #834
Merged
Merged
Conversation
… 2027-01-14 cook import ran on gpt-4o-mini (the library's built-in default; OPENAI_MODEL was not read). OpenAI removes that model on 2027-01-14. 0.12.0 defaults to gpt-6-luna with the request parameters it accepts, honours OPENAI_MODEL and OPENAI_REASONING_EFFORT, and moves title generation and text extraction to the same model.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cook importconverts with OpenAI through cooklang-import. The pinned 0.9.x usedgpt-4o-minias a built-in default and did not readOPENAI_MODEL. OpenAI removesgpt-4o-mini(andgpt-4o,gpt-4.1-mini) from its API on 2027-01-14, socook importwould start failing that day.cooklang-import 0.12.0 (cooklang/cooklang-import#81):
gpt-6-lunawith the request parameters it accepts, reasoning off;OPENAI_MODELandOPENAI_REASONING_EFFORT;No source changes here:
text_to_cooklangandurl_to_recipekeep their signatures. The lockfile moves a number of transitive dependencies with it (0.9.18 → 0.12.0 spans three minor releases).Checked:
cargo test --workspace(1,904 pass), clippy with all features, fmt, andcook importon a public recipe page.