Repository navigation
fix(auth): sign-up copy says confirm your email, then sign in with your password (planning#2291) - #54
Merged
Conversation
…ur password (planning#2291)
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No blocking issues — approved ✅; 3 nitpicks below. 🧹 Nitpicks (3) — 🟢 3 low
The change updates the sign-up confirmation messaging in both auth surfaces so users are told a confirmation email was sent and that they must follow it and sign in with their password, and adds a flow test for the panel's sign-up path.
Reviewed commit: 69ced65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After constructive-db#4092 (constructive-planning#2291), opening the sign-up verification link only verifies the email. It no longer signs the user in, and they then sign in with their password. Two sign-up success messages still said the link would "confirm your address and sign in":
This PR changes no logic, flows or GraphQL operations. The Console Kit verification path already ends with "Your email address has been verified. You can sign in now." I left
packages/sheets/dist-vendoralone because the release build regenerates it.Evidence (reproduce → fix)
New flow test in
auth-feature-pack.test.tsx: submit sign-up onAuthFeaturePack, then assert thestatusalert text.Before (pre-fix copy):
After:
Tests 11 passed (11). A full localpnpm check(build, lint, typecheck, all tests) also passes.Link to Devin session: https://app.devin.ai/sessions/bb4e1adfeb5f4489bbec4e94d65b68f7
Open in Devin Desktop: https://app.devin.ai/desktop/session/bb4e1adfeb5f4489bbec4e94d65b68f7?variant=devin
Requested by: @pyramation