Skip to content

fix(auth): sign-up copy says confirm your email, then sign in with your password (planning#2291) - #54

Merged
pyramation merged 1 commit into
mainfrom
feat/sign-up-verify-then-sign-in
Oct 19, 2026
Merged

pyramation merged 1 commit into
mainfrom
feat/sign-up-verify-then-sign-in

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

After constructive-db#4092 (constructive-planning#2291), opening the sign-up verification link only verifies the email. It no longer signs the user in, and they then sign in with their password. Two sign-up success messages still said the link would "confirm your address and sign in":

# apps/blocks/src/blocks/feature-packs/auth/auth-entry-panel.tsx (AuthFeaturePack sign-up feedback)
- Check your email for a link to confirm your address and sign in.
+ Check your email to confirm your address, then sign in with your password.

# packages/sheets/src/auth/ui/register-form.tsx (Sheets auth gate, same copy as dashboard)
- We've sent a link to confirm your address and sign in.
+ We've sent a link to confirm your address. Open it, then sign in with your password.

This PR changes no logic, flows or GraphQL operations. The Console Kit verification path already ends with "Your email address has been verified. You can sign in now." I left packages/sheets/dist-vendor alone because the release build regenerates it.

Evidence (reproduce → fix)

New flow test in auth-feature-pack.test.tsx: submit sign-up on AuthFeaturePack, then assert the status alert text.

Before (pre-fix copy):

× authentication feature-pack flows > tells a new account to confirm its email, then sign in with its password
  Expected element to have text content:
    Check your email to confirm your address, then sign in with your password.
  Received:
    Check your email for a link to confirm your address and sign in.
Tests  1 failed | 10 passed (11)

After: Tests 11 passed (11). A full local pnpm check (build, lint, typecheck, all tests) also passes.

Link to Devin session: https://app.devin.ai/sessions/bb4e1adfeb5f4489bbec4e94d65b68f7
Open in Devin Desktop: https://app.devin.ai/desktop/session/bb4e1adfeb5f4489bbec4e94d65b68f7?variant=devin
Requested by: @pyramation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@tenki-reviewer

tenki-reviewer Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Review complete. No blocking issues — approved ✅; 3 nitpicks below.

🧹 Nitpicks (3) — 🟢 3 low
  • 🟢 Sign-up test never asserts the signUp payload (auth-feature-pack.test.tsx:98) — The 'tells a new account to confirm its email' test asserts only the rendered status text and never checks what signUp received (auth-feature-pack.test.tsx:98).
  • 🟢 Registration success screen is not announced to screen readers (register-form.tsx:50) — After successful registration the form is replaced by the 'Check your email' success markup with no role='status' or aria-live wrapper (packages/sheets/src/auth/ui/register-form.tsx:48-62).
  • 🟢 Registration success screen is a sign-in dead end (register-form.tsx:48) — The new success copy tells users to 'sign in with your password' (packages/sheets/src/auth/ui/register-form.tsx:59), but the success screen renders no sign-in CTA: onShowLogin is only wired into the form view.

The change updates the sign-up confirmation messaging in both auth surfaces so users are told a confirmation email was sent and that they must follow it and sign in with their password, and adds a flow test for the panel's sign-up path.

Files Change
apps/blocks/src/blocks/feature-packs/auth/auth-entry-panel.tsx, packages/sheets/src/auth/ui/register-form.tsx Copy updated to a password-follow-up confirmation message after sign-up.
apps/blocks/src/blocks/feature-packs/auth/auth-feature-pack.test.tsx New flow test exercising the sign-up path of the entry panel.

Reviewed commit: 69ced65

@pyramation
pyramation merged commit 811eb4e into main Oct 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant