Skip to content

Darken light-mode coral text so emphasis clears WCAG AA - #149

Merged
VatsalSy merged 1 commit into
mainfrom
rayleigh-cloud/sync-coral-text-tokens-31fe
Oct 16, 2026
Merged

VatsalSy merged 1 commit into
mainfrom
rayleigh-cloud/sync-coral-text-tokens-31fe

Conversation

@VatsalSy

@VatsalSy VatsalSy commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Light-mode emphasis on the lab site used the coral fill (#cf4900). On paper (#f3efe8) that colour is about 3.97:1 and fails WCAG AA for normal text. This syncs the vendored design-system tokens to comphy-lab/comphy-design-system main c77c736, so <strong> uses #c04400 and the light coral chip label uses #b03c00.

Changes

  • Replaced assets/css/tokens.css with the file from design-system c77c736.
  • Pointed the bridge --color-strong alias at --c-accent-coral-text, because later stylesheets paint <strong> through that alias.
  • Set the inlined light .chip--coral label to #b03c00. Dark-mode colours are unchanged. The fill token stays #cf4900.

Testing

Homepage news row (Sanjay, V.), computed colour of <strong>:

  • Light before: rgb(207, 73, 0) (#cf4900)
  • Light after: rgb(192, 68, 0) (#c04400)
  • Dark before and after: rgb(255, 153, 102) (#ff9966)

Coral chip label on the same stylesheet stack: light #b03c00; dark unchanged.

Homepage news strong text, light, before
Homepage news strong text, light, after
Homepage news strong text, dark, before
Homepage news strong text, dark, after

CodeRabbit CLI is not installed here, so that local review was skipped. npm test was not run because node_modules is not installed in this environment.

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Style
    • Updated coral text colours for prominent text and coral chips across light and dark themes.
    • Coral chip backgrounds and borders remain unchanged.

Emphasis and the coral chip label used the fill coral, which fails
contrast on paper. Sync the vendored tokens to design-system c77c736
and point the inlined strong alias and chip label at the darker text.

Co-authored-by: Vatsal Sanjay | CoMPhy Lab <vatsal.sanjay@comphy-lab.org>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 09:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 748356ee-4f3d-495c-bddf-c3864e7471ac
📥 Commits

Reviewing files that changed from the base of the PR and between f3e8f66 and 49ccaca.

📒 Files selected for processing: 2
  • assets/css/bridge.css
  • assets/css/tokens.css

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout: 1
  • GitHub Check: build
🧰 Additional context used
📚 Code guidelines: 1
AGENTS.md — unknown
📓 Path-based instructions: 1
Source excerpt: Mobile-first CSS; min-width media queries.

📄 CodeRabbit inference engine (AGENTS.md)

Files:

  • assets/css/bridge.css
  • assets/css/tokens.css
🔇 Additional comments: 3
assets/css/tokens.css: 2

11-12: LGTM!

Also applies to: 139-140, 200-200

342-342: 🎯 Functional Correctness

The dark-theme rules already override both light-mode declarations:

  • assets/css/tokens.css:345 sets .chip--coral to #ff9966.
  • assets/css/bridge.css:195 sets .chip--coral to #f96, equivalent to #ff9966.

Both selectors are more specific and appear after the light declarations, so dark-mode chips do not use #b03c00. The proposed token change is not required.

assets/css/bridge.css: 1

33-33: LGTM!

📝 Walkthrough

The changes add a coral text token, use it for strong text, and set coral chip label text to #b03c00. The coral chip fill and border remain unchanged.

Changes: Coral text colours

Layer / File(s) Summary
Coral text token and consumers
assets/css/tokens.css, assets/css/bridge.css
A coral text token is added. Strong text uses the token, and coral chip labels use #b03c00. The dark-theme token maps to the coral fill colour. The chip fill and border declarations are unchanged.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: cursoragent

Merge Risk: ⚪ Minimal · up to 49cca

The light-mode coral text colors are darkened, and the existing dark-mode colors are preserved. No material merge risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: darkening light-mode coral text to meet WCAG AA contrast requirements.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@comphy-bot

comphy-bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

comphy-bot review status for comphy-lab/comphy-lab.github.io#149 at 49ccacae: completed

Review completed for this exact pull request head.

@comphy-bot
comphy-bot self-requested a review October 16, 2026 09:44

@comphy-bot comphy-bot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the exact head 49ccaca (+12/-5 across two CSS files).

No P0/P1 findings. The new text token is wired through both strong-text declarations and the legacy bridge alias; the coral fill remains unchanged. The darker chip-label declarations preserve the existing more-specific dark-theme overrides.

Verification: inspected all changed CSS and current peer-review evidence. The exact-head build and PR-hygiene checks succeeded; the packet conflict-marker and whitespace checks passed. No PR code or test scripts were executed. Browser/computed-style examples in the PR description were not independently rerun. No new automated contrast-regression test is included in this diff.

@VatsalSy
VatsalSy merged commit db29615 into main Oct 16, 2026
4 checks passed
@VatsalSy
VatsalSy deleted the rayleigh-cloud/sync-coral-text-tokens-31fe branch October 16, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants