Repository navigation
Darken light-mode coral text so emphasis clears WCAG AA - #149
Conversation
Emphasis and the coral chip label used the fill coral, which fails contrast on paper. Sync the vendored tokens to design-system c77c736 and point the inlined strong alias and chip label at the darker text. Co-authored-by: Vatsal Sanjay | CoMPhy Lab <vatsal.sanjay@comphy-lab.org>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
comphy-bot review status for Review completed for this exact pull request head. |
comphy-bot
left a comment
There was a problem hiding this comment.
Reviewed the exact head 49ccaca (+12/-5 across two CSS files).
No P0/P1 findings. The new text token is wired through both strong-text declarations and the legacy bridge alias; the coral fill remains unchanged. The darker chip-label declarations preserve the existing more-specific dark-theme overrides.
Verification: inspected all changed CSS and current peer-review evidence. The exact-head build and PR-hygiene checks succeeded; the packet conflict-marker and whitespace checks passed. No PR code or test scripts were executed. Browser/computed-style examples in the PR description were not independently rerun. No new automated contrast-regression test is included in this diff.
Summary
Light-mode emphasis on the lab site used the coral fill (
#cf4900). On paper (#f3efe8) that colour is about 3.97:1 and fails WCAG AA for normal text. This syncs the vendored design-system tokens tocomphy-lab/comphy-design-systemmainc77c736, so<strong>uses#c04400and the light coral chip label uses#b03c00.Changes
assets/css/tokens.csswith the file from design-systemc77c736.--color-strongalias at--c-accent-coral-text, because later stylesheets paint<strong>through that alias..chip--corallabel to#b03c00. Dark-mode colours are unchanged. The fill token stays#cf4900.Testing
Homepage news row (
Sanjay, V.), computed colour of<strong>:rgb(207, 73, 0)(#cf4900)rgb(192, 68, 0)(#c04400)rgb(255, 153, 102)(#ff9966)Coral chip label on the same stylesheet stack: light
#b03c00; dark unchanged.CodeRabbit CLI is not installed here, so that local review was skipped.
npm testwas not run becausenode_modulesis not installed in this environment.Summary by CodeRabbit