Skip to content

MsgpackEmitter.emitInteger() has useless bounds checks #47

Closed
Bug
Closed
MsgpackEmitter.emitInteger() has useless bounds checks#47
Bug
Assignees
JarrodCTaylor
Labels
performance

Description

@puredanger
puredanger
opened on Feb 24, 2026

MsgpackEmitter.emitInteger() has bounds checks to handle longs outside of long range, which is impossible:

if ((i > Long.MAX_VALUE) || (i < Long.MIN_VALUE))
  ...

These conditions are always false and should be removed in both emitInteger() methods.

Activity

  1. puredanger
    added the
    Bug
    issue type on Feb 24, 2026
  2. puredanger
    assigned
    JarrodCTaylor
    on Feb 24, 2026
  3. puredanger
    added
    performance
    on Feb 24, 2026

  4. JarrodCTaylor commented on Feb 27, 2026

    @JarrodCTaylor
    JarrodCTaylor
    on Feb 27, 2026
    Contributor

    Closed by #49

  5. JarrodCTaylor
    closed this as completedon Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

performance

Type

Bug

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions