Skip to content

The task hash writes a queue_name field nobody reads #79

Description

@codingjoe

Found while reviewing PR #69 with the SuperJoe crew, filed as out-of-scope there.

RedisTaskBackend.enqueue() stores queue_name in the task hash, and nothing reads it: the acquire and mover scripts read data and score, the reaper checks existence only, and every reader takes the queue from the payload's task.queue_name or from the key it found the id under. It is one field written per enqueue with no consumer.

Either drop it, or make a reader use it instead of carrying the queue name in the payload as well.

Reference: threadmill/backends/redis.py, the enqueue hash mapping.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions