Skip to content

chore: update CI actions, fix lint warnings, harden debugpy tests - #4

Merged
cmaranes merged 3 commits into
mainfrom
chore/ci-and-lint-cleanup
Oct 22, 2026
Merged

cmaranes merged 3 commits into
mainfrom
chore/ci-and-lint-cleanup

Conversation

@cmaranes

@cmaranes cmaranes commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

Summary

Follow-up to #3, based on the warnings in the v0.1.0 release run.

  • CI: bumps every action to its current major, all on Node 24: checkout@v7, setup-node@v7, setup-python@v7, cache@v6, upload-artifact@v7 and download-artifact@v8. The build moves from Node 20 (EOL) to Node 22. I checked the release notes for each major: the breaking changes only affect self-hosted runners or downloads by artifact ID. download-artifact v8 now fails on a hash mismatch, which is what we want for a release.
  • Lint: fixes the 4 pre-existing warnings: camelCase static constants and braces on an if. No behavior change.
  • Debugpy integration test hardened. On CI, the debugger occasionally never reported stopping at the breakpoint, failing the suite on Ubuntu and Windows.
    • The fixture now calls breakpoint() instead of relying on an editor breakpoint. That removed one race, but the flake still happened about 1 in 25 jobs afterwards.
    • The suite therefore retries the debugger start once. On failure it reports the Debug Adapter Protocol traffic and the activeStackItem state. A consistent failure still fails, and if the flake recurs we'll have the evidence to find its root cause.
    • The retry path was verified locally by forcing the first attempt to time out.
  • Stale files: the suite clears .vscode/ply_preview in the fixture workspace first. A manual F5 session that never terminated had left a .ply behind, and the file-count assertions counted it.

Not solved

The root cause of the rare missed stop is unknown. 15 instrumented CI jobs in a row passed, so no failure log was captured.

Test plan

  • npm run lint: 0 problems
  • npm test locally: 6/6, including with the first debugger start forced to fail
  • Since the breakpoint() change, 1 failure in about 25 CI jobs; 15 consecutive instrumented jobs passed
  • CI green on the final commit

🤖 Generated with Claude Code

https://claude.ai/code/session_01JBDmV8VxTwVxxpuC8NMG8y

@cmaranes
cmaranes force-pushed the chore/ci-and-lint-cleanup branch 2 times, most recently from c117cac to c100b7c Compare October 22, 2026 13:52
@cmaranes cmaranes changed the title chore: update CI actions, fix lint warnings, harden tests chore: update CI actions, fix lint warnings and a flaky test Oct 22, 2026
cmaranes and others added 3 commits October 22, 2026 16:32
checkout v7, setup-node v7, setup-python v7, cache v6,
upload-artifact v7, download-artifact v8 (fails on digest mismatch).
Removes the Node 20 action-runtime deprecation warnings; Node 20 itself
is end-of-life.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JBDmV8VxTwVxxpuC8NMG8y
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JBDmV8VxTwVxxpuC8NMG8y
- The fixture stops via breakpoint() instead of an editor breakpoint,
  which raced with debugpy startup on slow runners.
- On CI the debugger still occasionally (~1 in 25 jobs) never reports
  the stop. The suite now retries the debugger start once, and a
  failure includes the Debug Adapter Protocol traffic and the
  activeStackItem state so the cause can be diagnosed if it recurs.
- Clear the preview folder first: a manual F5 session that never
  terminated left a .ply that the file-count assertions counted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JBDmV8VxTwVxxpuC8NMG8y
@cmaranes
cmaranes force-pushed the chore/ci-and-lint-cleanup branch from c2735bd to 3823afa Compare October 22, 2026 14:32
@cmaranes cmaranes changed the title chore: update CI actions, fix lint warnings and a flaky test chore: update CI actions, fix lint warnings, harden debugpy tests Oct 22, 2026
@cmaranes
cmaranes merged commit 9f5b2e7 into main Oct 22, 2026
3 checks passed
@cmaranes
cmaranes deleted the chore/ci-and-lint-cleanup branch October 22, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant