Repository navigation
Whisper cpp v1.9.4 - #1
Merged
Merged
Conversation
- Bump vendor submodule to v1.9.4 and re-sync public headers - Bundle the new per-kind Metal kernel sources (kernels/*.metal) plus ggml-common.h and ggml-metal-impl.h; ggml now resolves their includes at runtime, which also fixes the "'ggml-common.h' file not found" Metal compile failure that crashed Parakeet model loading - Drop the single-file ggml-metal.metal and the pre-merged copy - Compile new iqp.cpp and ggml-metal-tuning.cpp; exclude ggml-et and vitisai backends - Add generated/ggml-version.h in place of the CMake-generated header - Update CLAUDE.md with the new layout and version bump steps Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the popover's Quit button called AppState.shutdown(). Quitting via SwiftUI's built-in Quit menu item (Cmd+Q) or other system-initiated termination went straight to exit(), where ggml's static Metal device registry was destroyed while model buffers were still alive, tripping GGML_ASSERT([rsets->data count] == 0). Add an AppDelegate whose applicationShouldTerminate defers termination until shutdown() has unloaded the model, and simplify the Quit button to just call terminate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
transcriptionLanguage is a computed property backed by UserDefaults, which @observable doesn't track, so the picker never re-rendered after a selection. Register the read/write with access(keyPath:) and withMutation(keyPath:) so bound views update. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Raise macOS deployment target to 27.0 - Change development team - Add Xcode per-user scheme and workspace state Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plus some fixes