Repository navigation
Write pip extras with double quotes: single quotes break in Windows cmd (v3.1.20) - #87
Merged
Merged
Conversation
…md (v3.1.20) pip install '.[full]' is valid pip syntax and installs the checkout with the extra (verified in a fresh venv), but in Windows cmd.exe single quotes are not quoting characters: pip receives the quotes literally and fails with "Invalid requirement". Double quotes work in bash, zsh, PowerShell and cmd alike, so README (EN/UK), INSTALL.md, requirements.txt, the config-examples README, the CLI hints for --encrypt, CI and CLAUDE.md use them. The README install snippet starts with cd into the checkout. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XT6iUWaQgahXDB9TWX9Bq7 Generated-With: Claude Code 2.1.42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The maintainer questioned
pip install '.[full]'in the README. The syntax itself is right — pip accepts a local path with extras, and a fresh venv installs the checkout withcryptographyandpyyamlfrom it — but in Windowscmd.exesingle quotes are not quoting characters: pip receives'.[full]'literally and fails with "Invalid requirement". Double quotes work in bash, zsh, PowerShell and cmd alike.docs/INSTALL.md,requirements.txt,docs/config-examples/README.md, the CLI hints for--encrypt(pip install "data-masking[security]"),.github/workflows/ci.ymlandCLAUDE.mduse double quotes for every extras spec.cd data-maskingso it is clear the command runs from the repository root.Verification
pytest: 1533 passed, 1 skipped; mypy 0 errors; flake8 clean (the CLI module imports — the hint strings were re-quoted by hand).pip install ".[full]"from the checkout in a fresh venv: installs 3.1.x with both extras,data-mask --versionworks.Generated by Claude Code