Skip to content

ditching three-dicts implementation for annotation prop "magics" - #413

Merged
keighrim merged 9 commits into
developfrom
411-fix-three-dicts
Nov 1, 2026
Merged

keighrim merged 9 commits into
developfrom
411-fix-three-dicts

Conversation

@keighrim

@keighrim keighrim commented Nov 1, 2026

Copy link
Copy Markdown
Member

fixing #411

@clams-bot clams-bot added this to infra Nov 1, 2026
@github-project-automation github-project-automation Bot moved this to Todo in infra Nov 1, 2026
@codecov

codecov Bot commented Nov 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.84689% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.17%. Comparing base (945894e) to head (ed0597c).

Files with missing lines Patch % Lines
mmif/serialize/annotation.py 95.08% 3 Missing ⚠️
mmif/utils/video_document_helper.py 92.68% 3 Missing ⚠️
mmif/serialize/mmif.py 98.58% 2 Missing ⚠️
mmif/serialize/view.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #413      +/-   ##
===========================================
+ Coverage    78.62%   80.17%   +1.54%     
===========================================
  Files           27       28       +1     
  Lines         3416     3627     +211     
===========================================
+ Hits          2686     2908     +222     
+ Misses         730      719      -11     
Flag Coverage Δ
unittests 80.17% <97.84%> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@keighrim keighrim linked an issue Nov 1, 2026 that may be closed by this pull request
@keighrim
keighrim merged commit a2fe1ad into develop Nov 1, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in infra Nov 1, 2026
@keighrim
keighrim deleted the 411-fix-three-dicts branch November 1, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

redesigning Annotation and Document property handling

1 participant