Repository navigation
Conversation
fquffio
changed the title
secure.php.net/get/... now returns 404, and its TLS setup is rejected by Stretch's GnuTLS (alert 70: protocol version).
fquffio
changed the title
fquffio
marked this pull request as ready for review
October 21, 2026 16:10
le0m
approved these changes
Oct 21, 2026
There was a problem hiding this comment.
🔵 Needs a closer look
Retry cleanup remains unresolved, and legacy PEAR/TLS compatibility needs full-matrix build validation and human review.
1 open issue
What changed in this PR
Improves build reliability for legacy PHP images and keeps CI matrix jobs running independently.
Changes:
- Upgrades PEAR before extension installation and adds three-attempt retries.
- Updates PHP 5.6 source and signature download URLs.
- Disables fail-fast across test and publish matrices.
| File | Description |
|---|---|
| xhprof/Dockerfile | Retries XHProf installation. |
| pcov/Dockerfile | Retries PCOV installation. |
| otel/Dockerfile | Retries telemetry extension installation. |
| Dockerfile.alpine | Upgrades PEAR and retries extensions. |
| Dockerfile | Upgrades PEAR and retries extensions. |
| dev/Dockerfile | Retries Xdebug installation. |
| compat/Dockerfile.5.6-fpm | Updates downloads, PEAR, and retries. |
| compat/Dockerfile.5.6-apache | Updates downloads, PEAR, and retries. |
| compat/Dockerfile.5.6 | Updates downloads, PEAR, and retries. |
| .github/workflows/test.latest.yml | Disables matrix fail-fast. |
| .github/workflows/test.compat.yml | Disables matrix fail-fast. |
| .github/workflows/test.8.yml | Disables matrix fail-fast. |
| .github/workflows/test.7.yml | Disables matrix fail-fast. |
| .github/workflows/test.5.yml | Disables matrix fail-fast. |
| .github/workflows/publish.latest.yml | Disables matrix fail-fast. |
| .github/workflows/publish.compat.yml | Disables matrix fail-fast. |
| .github/workflows/publish.8.yml | Disables matrix fail-fast. |
| .github/workflows/publish.7.yml | Disables matrix fail-fast. |
| .github/workflows/publish.5.yml | Disables matrix fail-fast. |
Review effort: Balanced
| && if [ "${PHP_VERSION%%.*}" = "7" ]; then \ | ||
| install-php-extensions amqp \ | ||
| && install-php-extensions $(echo "$PHP_EXTENSIONS" | sed 's/amqp//'); \ | ||
| retry install-php-extensions amqp \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No releases available for package …). Upgrade PEAR to 1.10.18 before installing extensions.install-php-extensionsup to 3 times to absorb transient PECL errors.secure.php.net/get/…returns 404 and rejects Stretch's TLS. Download sources fromwww.php.net/distributions/instead.fail-fast: falseon all matrices.