Repository navigation
Remove hardcoded groups in eoswrapper - #86
Open
jessegeens wants to merge 1 commit into
Open
jessegeens wants to merge 1 commit into
jessegeens wants to merge 1 commit into
Conversation
Assisted-by: Claude:claude-opus-5-5
rawe0
self-requested a review
October 16, 2026 12:00
diocas
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to cs3org/reva#5898 and cs3org/reva#5900 we are finally able to remove the hardcoded groups from the eoswrapper.
Note that this introduces a behaviour change though: revisions are now accessible to all people with the right role. E.g. readers will be able to download revisions, writers will be able to restore them. This used to be the case for project members, but not for receivers of a share.