Repository navigation
fix(blobExec): denylist only the 4 StatTimes.h blobs that still hang - #108
Merged
Merged
Conversation
srcML 1.1.0 did not terminate on 8 Java blobs with annotated array dimensions (srcML/srcML#2361). #104 moved srcML to develop d38271916. Develop parses all 8 blobs. Each one gives exit 0 and a token stream of 1,154 to 2,588 lines in 0.07 s or less. The denylist kept them out of the dataset for no reason. The 4 StatTimes.h blobs stay on the list. Develop still does not end on them within 120 s, and the minimal reproducer still hangs. Their reason now names both srcML versions. BlobDenylistSpec now asserts the 4 entries, and a new test asserts that the 8 Java blobs are not on the list. The lookup tests use a C entry. The WalkerIntegrationSpec fixture no longer cites #2361. DATASET.md said that the denylist holds 209 blobs in three srcML 1.1.0 defects. #102 removed the 197 crash entries, and this commit removes the 8 Java entries. README.md gave 12 entries. Both now give the 4 StatTimes.h blobs, which srcML 1.1.0 and develop d38271916 do not end on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The blob denylist holds 12 blobs. srcML 1.1.0 did not end on them. 8 of them are Java blobs with annotated array dimensions (srcML/srcML#2361). #104 moved srcML to develop d38271916. Develop parses the 8 Java blobs. Thus the denylist keeps 8 good blobs out of the dataset.
DATASET.md says that the denylist holds 209 blobs in three srcML 1.1.0 defects. #102 removed the 197 crash entries. README.md says 12 entries.
Change
BlobDenylistEntries.scaladrops the 8 Java entries. It keeps the 4eden/fs/utils/StatTimes.hentries. Their reason names srcML 1.1.0 and develop d38271916.BlobDenylistSpecasserts the 4 entries. A new test asserts that the 8 Java blobs are not on the list. The lookup tests use a C entry.WalkerIntegrationSpecfixture entry and comments no longer cite #2361.Measured with
tokenizeSrcMl.pland the devenv build (develop d38271916). All 12 blobs ran in parallel with a cap of 120 s:The minimal reproducer
namespace n{struct T&f(const struct S);}still hangs on develop (timeout at 30 s).Not changed
srcml-nontermination-analysis.md#.... That file is not in this repository.devenv.nix,nix/, and test fixtures.Tests
devenv shell -- bash -c 'cd blobExec && sbt -batch test assembly': 185 passed.make testintokenize/srcMLtokenandtokenize/rustTokenizer: pass.tests/test_token_worker.sh: pass.prove tests/t: 239 passed.tests/{tokenize_gate,pipeline_workdir_guard,ensure_artifacts,retokenize_passthrough,reblame_passthrough}.sh: 50, 79, 42, 34, 15 passed.pytest -q: 82 passed.