Repository navigation
MCP returns figures, qc dry run and plots, run results, typed flags; version 0.18.4 - #40
Merged
Merged
Conversation
…version 0.18.4 - metagene and pwm take --figure PREFIX: the view's figure as PDF and PNG, drawn without a terminal. The MCP tools pass it by default and return the PNG as an image; pileup's Miami SVG comes back as an image too. - qc --dry-run prints, as TSV, what the cell QC keeps per batch and what each --site-* threshold removes per modality (alone, and only by it); nothing is written. qc --batch-process --plots draws the view's qc_plots/ figures headlessly. qc_plots/ now holds PNG beside PDF, as documented. The MCP qc tool takes dry_run and plots. - Every MCP result for a directory carries the `results` of its run records (a fit's R-hat, cluster sizes), which the child only logged. - Common flags have typed MCP arguments (barcode tags, gene type, mixture, run's skips and depth resolution, cluster's shift, seed, profile strength and holdout, pileup's membership, top modality and tracks, metagene's isoforms and non-coding), checked against each command's own flags by a test. - apa takes utr_bed; options refuses the stale -I/--interactive no more and says when a flag has its own argument; modules' data is described as a cluster output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rest of the MCP audit: what an agent couldn't see or set. Follows #39, now merged.
Figures come back as images
faba metageneandfaba pwmtake--figure PREFIX: the view's figure as{PREFIX}.pdfand.png, drawn without a terminal, so with--batch-processtoo. The MCPmetageneandpwmtools pass it by default (figure: falseturns it off) and return the PNG as an image beside the table.pileup's Miami SVG is also returned as an image, at most 1600 px wide.figure::pngandfigure::save_with_png.qc: try thresholds first, and plots in batch
faba qc --dry-runprints TSV and writes nothing: per batch, what the cell QC keeps; per modality, what each--site-*threshold removes, alone and only by it. Needs INPUT_DIR only. The MCPqctool'sdry_runreturns it as rows.faba qc --batch-process --plotsdraws the view'sqc_plots/figures headlessly: every modality and knob, with the metagene once the annotation is read. The MCPplotsreturns up to eight as images.qc_plots/now holds a PNG beside each PDF, as the docs already said.picker()andsite_views();Meta::waitblocks for the annotation.Results that only went to stderr
Every MCP result for a directory now carries the
resultsof its*.run.jsonrecords, by job: a fit's R-hat, cluster sizes, and so on. Over 16 KiB it points to the file instead.Typed flags
Common flags have their own arguments, from one
TYPEDtable that also builds the schemas:run's skips and depth resolutioncluster's shift, seed, profile strength and holdoutpileup's membership, top modality and tracksmetagene's isoforms and non-codingThey are put ahead of
options, so the existing checks still apply. A test checks each one against the command's real clap flags.Small fixes
apatakesutr_bed.optionsno longer lists the stale-I/--interactive, and says when a flag has its own argument.modules'datais described as a cluster output.Version
0.18.4.
Testing
cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass: 740 unit tests plus the integration suites.faba qc --dry-runand--plotson the synthetic fileset.save_with_png.--features hdf5(this branch touches no hdf5 code), and a full MCP session end to end.