Repository navigation
faba's terminal views as detachable sessions - #34
Merged
Merged
Conversation
pwm, pileup, metagene, qc, modules and run views run through legume-tui on data-beans 0.9's session screens: they survive a dropped connection, ctrl+alt+d detaches, ctrl+alt+s switches, and starting a view again with nothing named offers the live sessions. New attach, sessions, kill and rename subcommands; --no-detach runs in the terminal only; cluster runs plain. - One screen per command; the session keys sit at the end of the title row and the logo stands clear of them. - Figures pick their drawing method through the crate for the attached terminal (FABA_TUI_IMAGES still overrides), and pictures are made again after an attach. - kill takes the quit path: changed thresholds are dropped without asking, a write under way finishes; a run is interrupted, given a grace, then stopped with its group. - faba's own copy of the child runner gives way to legume_tui::child.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
faba's views now run through legume-tui (0.3.3) on data-beans 0.9's session screens, as senna, pinto, lupin and data-beans already do: they survive a dropped connection and can be left and resumed, with images intact.
attach,sessions,kill,renamesubcommands;--no-detachruns in the terminal only.faba clusterand batch runs stay plain.FABA_TUI_IMAGESstill overrides); pictures are made again after an attach.killtakes the quit path: qc drops changed thresholds without asking, a write under way finishes;faba runis interrupted, given a grace, then stopped with its process group (the pipeline does not read the interrupt, so a step may leave partial output, as pressingstwice does today).legume_tui::child.Tests drive the real binary through pseudo-terminals: hosted start, dropped client, reattach with images sent again, kill, the target rule and resume picker,
--no-detach, and an early error staying on screen.