Repository navigation
Conversation
In a terminal, faba modules now shows the blockmodel's settings before it fits (no tables yet, --refit, or settings that differ from the record). Rows are prefilled from the flags given, else the preset's defaults; a preset switch refills the rows the user has not set. Every key re-checks the settings with clap and the cluster checks, the reason is shown beside the row and in the status line, and Ctrl+R is blocked until they pass. Ctrl+R fits, Esc goes back (to the old tables when there are any), Ctrl+C quits. The fit, the run record and the saved command use the values chosen. Batch mode and non-terminal runs use the flags as before. The pipeline's generic flag form moves to crate::tui::form so both screens share it, including the row drawing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
faba modulesin a terminal now asks for the blockmodel's settings before it fits. That happens when there are no tables yet, with--refit, or when the settings given differ from the run record.rresets a row.{m}_blockmodel.cmd.shuse the values chosen.--batch-process,--html) and non-terminal runs skip the form and use the flags as before.Refactor
The pipeline's generic flag form moves from
pipeline/tui/form.rstocrate::tui::form, so the pipeline Flags screen and the fit form share the form model, the parsing and the row drawing.Tests
New tests in
cluster/browse/tests/ask.rscover prefill, preset refill, blocked invalid settings (with the reason in the blocked note), Ctrl+R with edited and in-progress values, Esc vs Ctrl+C, the footer's Esc label, defaults given as flags, and batch mode skipping the form. The existing pipeline form tests pass. Checked live in a terminal on a small sample.