You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
nostream@3.12.0
Minor Changes
#1034e410a75 Thanks @Ferryx349! - feat(peering): treat authenticated peers as feeds, not clients
Adds limits.peer, a separate limit set for connections that have proven a
configured peering.peers pubkey with NIP-42 AUTH. Peer subscriptions use limits.peer.subscription instead of limits.client.subscription, and peer
messages use limits.peer.message in a separate rate-limit bucket, so a
full-feed subscription cannot trip the client EWMA limiter or the client max_subscriptions cap.
Peers are eligible for full feeds by default: maxLimit is uncapped and the
subscription caps are higher. An omitted peer REQ limit queries the full
stored feed instead of the client 500-event default, and peer filter counts are
not rejected by the protocol's former fixed ten-filter cap. Raw filter counts are
still bounded before deduplication, and stored reads wait for the socket's
send-flush callback so a slow peer cannot grow worker memory. Deleted and expired rows
are excluded in SQL before the limit, so they cannot consume a page slot.
A high but finite peer message rate keeps the credential from becoming an
unbounded egress path. Unauthenticated or unconfigured connections keep the
existing client limits exactly as before. The new limits are validated with the
rest of the settings document and documented in CONFIGURATION.md and docs/PEERING.md.
Summary by CodeRabbit
New Features
Authenticated peers now have separate subscription and message rate limits, with configurable peer limits.
Full-feed requests support higher subscription caps and can omit a default result limit. The fixed ten-filter cap is removed, while raw filter counts remain bounded.
Feed reads are paced until socket data is flushed. Deleted and expired records are excluded before applying result limits.
Unauthenticated or unconfigured connections retain existing client limits.
No actionable comments were generated in the recent review.
Recent review info
Automatic approval policy
Commit: 888d9d8ba25c.
Setting
Effective value
Source
Automatic approvals
Enabled
Global configuration
Merge risk
Minimal
Global configuration
Security risk
Not set
Global configuration
Not set means no limit was configured after inheritance. Use @coderabbitai configuration to inspect the resolved settings and their sources.
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: df0f1052-02df-42e6-9817-3017a4c32949
Commits
Reviewing files that changed from the base of the PR and between bc6d2bb and 888d9d8.
Files selected for processing: 4
.changeset/astro-7-website.md
.changeset/peering-feed-treatment.md
CHANGELOG.md
package.json
Files with no reviewable changes: 2
.changeset/peering-feed-treatment.md
.changeset/astro-7-website.md
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Walkthrough
The package version changes from 3.11.0 to 3.12.0. The changelog adds 3.12.0 release notes about authenticated-peer feed handling. Two changeset files are removed.
Changes: 3.12.0 Release Metadata
Layer / File(s)
Summary
Record the 3.12.0 release CHANGELOG.md, package.json, .changeset/peering-feed-treatment.md, .changeset/astro-7-website.md
The changelog describes peer-specific feed limits and handling, and the package version changes to 3.12.0. The peer-treatment and Astro website changesets are removed.
Issue 934 concerns separate limits for authenticated configured peers. The 3.12.0 changelog records those peer-specific limits.
Issue 931 concerns peer-aware connection limits. The 3.12.0 changelog documents the peer limits.
Possibly related PRs
cameri/nostream#1038: This PR added the Astro website changeset that this release removes.
cameri/nostream#1034: This PR implements the peer-feed behavior described in this release’s changelog.
cameri/nostream#1031: This PR releases peer limits that use authenticated peer identity.
Merge Risk: Minimal · up to 888d9
No actionable merge-blocking risk remains in the release metadata.
Architecture risk: Low · up to 888d9
The change affects 2 systems.
Changed systems:CHANGELOG.md, package.json
Architecture concerns
No architecture-level concerns identified.
Review details
Systems and components
observed — CHANGELOG.md (service) was modified; 1 changed file maps to changed impact.
observed — package.json (service) was modified; 1 changed file maps to changed impact.
Before / after behavior
observed — Modified behavior in CHANGELOG.md: Adds the 3.12.0 release notes for authenticated-peer feed treatment, separate peer limits and rate limiting, full-feed defaults, filter and storage-read constraints, finite peer message rates, and configuration validation and documentation. The entry states that unauthenticated or unconfigured connections retain existing client limits.
observed — Modified behavior in package.json: The package version is updated from 3.11.0 to 3.12.0.
observed — Modified behavior in .changeset/astro-7-website.md: The changeset entry describing the Astro and Sharp dependency update, its private-workspace and release-set status, and the cited advisories was removed.
observed — Modified behavior in .changeset/peering-feed-treatment.md: Removed the changeset declaring a minor nostream release and describing the authenticated-peer feed behavior and related limits, query defaults, filtering, read pacing, row exclusions, and documentation updates.
Pre-merge checks: 4 · 1
Failed checks: 1 inconclusive
Check name
Status
Explanation
Resolution
Title check
The title "chore: release new version 🚀" is generic. It names a release but not the package, the version, or the feature. The changeset covers authenticated peer limits for nostream 3.12.0, so the tit…
Replace the title with a specific one that names the package, the version, and the main change. For example: "chore(release): nostream 3.12.0 with authenticated peer limits". Remove the emoji.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Full details: Title check
Explanation
The title "chore: release new version 🚀" is generic. It names a release but not the package, the version, or the feature. The changeset covers authenticated peer limits for nostream 3.12.0, so the title does not describe the main change. It is not off-topic, because the PR is a release PR, but it is too vague for a teammate scanning history to learn what changed.
Resolution
Replace the title with a specific one that names the package, the version, and the main change. For example: "chore(release): nostream 3.12.0 with authenticated peer limits". Remove the emoji.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit reads the release with care, Peer-feed notes are gathered there. Three point twelve is now in view, Old changesets bid adieu. The rabbit hops through pages bright, And nibbles changelog through the night.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
nostream@3.12.0
Minor Changes
#1034
e410a75Thanks @Ferryx349! - feat(peering): treat authenticated peers as feeds, not clientsAdds
limits.peer, a separate limit set for connections that have proven aconfigured
peering.peerspubkey with NIP-42 AUTH. Peer subscriptions uselimits.peer.subscriptioninstead oflimits.client.subscription, and peermessages use
limits.peer.messagein a separate rate-limit bucket, so afull-feed subscription cannot trip the client EWMA limiter or the client
max_subscriptionscap.Peers are eligible for full feeds by default:
maxLimitis uncapped and thesubscription caps are higher. An omitted peer REQ
limitqueries the fullstored feed instead of the client 500-event default, and peer filter counts are
not rejected by the protocol's former fixed ten-filter cap. Raw filter counts are
still bounded before deduplication, and stored reads wait for the socket's
send-flush callback so a slow peer cannot grow worker memory. Deleted and expired rows
are excluded in SQL before the limit, so they cannot consume a page slot.
A high but finite peer message rate keeps the credential from becoming an
unbounded egress path. Unauthenticated or unconfigured connections keep the
existing client limits exactly as before. The new limits are validated with the
rest of the settings document and documented in
CONFIGURATION.mdanddocs/PEERING.md.Summary by CodeRabbit