Repository navigation
webapi-session: the wire's last answer — status and headers as received (zenbridge #2377) - #49
Merged
Merged
Conversation
A step that reads a header the contract does not type (an error id a failure names, zenbridge #2377) had nowhere to read it from: both transports typed the response and dropped the raw headers. The session now keeps the last answer's status and headers in ClientsState — recorded by both transports (none after a transport failure), cleared by beginStep like the step headers — and getLastResponse reads them. Inert until something reads it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ZhWx2wwpdS6d9hk35fStD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A step that reads a header the contract does not type (an error id a failure names — zenbridge #2377, the typed step errors in dhall-do-api) had nowhere to read it from: both transports typed the response and dropped the raw headers.
The session now keeps the last answer's status and headers in
ClientsState— recorded by both transports (none after a transport failure), cleared bybeginSteplike the step headers — andgetLastResponsereads them. Additive: inert until something reads it;testClientWithkeeps its shape (testClientRawWithbeside it answers the raw pair).Consumed by dhall-do-api
feature/2377-typed-step-errors(StepHttpFailedkeeps the headers the run config selects) and pinned by zenbridge'scabal.base.sources.projectat this branch's head.🤖 Generated with Claude Code
https://claude.ai/code/session_012ZhWx2wwpdS6d9hk35fStD