Skip to content

fix(web): drop duplicate PR icons beside PR labels - #1089

Merged
Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/duplicate-pr-merge-icons-59d302
Oct 5, 2026
Merged

Zach Dunn (zachdunn) merged 1 commit into
mainfrom
claude/duplicate-pr-merge-icons-59d302

Conversation

@zachdunn

Copy link
Copy Markdown
Member

In plain terms

Since #1085, the PR label draws its own state icon (open, merged, closed). Several places still put the old pull-request or issue icon in front of it, so the same PR showed two icons side by side. This removes the extra icon so each PR or issue reference shows one icon.

What it does / what it is not

  • Shows one icon in the screenshot hover card, the thumbnail captions on the Screenshots views, the Files filter chip and PR match banner, and the "connected work" rows in the workspace rail.
  • Keeps the plain kind icon when there is no PR label to show (the plain-text fallback), so those rows still have an icon.
  • Removes the githubKindSvg helper and the rail icon CSS, which nothing uses now.
  • Does not change PrLabel or the gallery and file page bylines. Those show a kind icon without a PR label beside it.

Technical notes

The rail tests used to check for the separate octicon's <title>. They now check the label's aria-label (which names the kind), that the row has exactly one <svg>, and that pull requests and issues get different data-icon values.

Test plan

  • pnpm --filter ./apps/web exec vitest run: 1250 passed
  • astro check: 0 errors
  • oxlint and oxfmt clean on the changed files
  • Check visually on a signed-in workspace (hover card, Screenshots captions, Files PR filter chip and banner, rail)

PrLabel draws its own state icon since #1085, but the hover card,
screenshot captions, Files filter chip, PR match banner, and rail
connected-work rows still put the old kind glyph in front of it. Keep the
kind glyph only for the plain-text fallback, and remove the now-unused
githubKindSvg helper and rail icon CSS.
@changeset-bot

changeset-bot Bot commented Oct 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5df659d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (2)
  • coderabbit:review
  • review
🚫 Excluded labels (none allowed) (1)
  • wip

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 21db61e8-f15b-4da5-aaac-d8a77633e10b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
uploads-web 5df659d Commit Preview URL

Branch Preview URL
Oct 05 2026, 01:38 PM

@zachdunn
Zach Dunn (zachdunn) merged commit 24addeb into main Oct 5, 2026
4 checks passed
@zachdunn
Zach Dunn (zachdunn) deleted the claude/duplicate-pr-merge-icons-59d302 branch October 5, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant