Repository navigation
fix(web): drop duplicate PR icons beside PR labels - #1089
Conversation
PrLabel draws its own state icon since #1085, but the hover card, screenshot captions, Files filter chip, PR match banner, and rail connected-work rows still put the old kind glyph in front of it. Keep the kind glyph only for the plain-text fallback, and remove the now-unused githubKindSvg helper and rail icon CSS.
|
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
uploads-web | 5df659d | Commit Preview URL Branch Preview URL |
Oct 05 2026, 01:38 PM |
In plain terms
Since #1085, the PR label draws its own state icon (open, merged, closed). Several places still put the old pull-request or issue icon in front of it, so the same PR showed two icons side by side. This removes the extra icon so each PR or issue reference shows one icon.
What it does / what it is not
githubKindSvghelper and the rail icon CSS, which nothing uses now.PrLabelor the gallery and file page bylines. Those show a kind icon without a PR label beside it.Technical notes
The rail tests used to check for the separate octicon's
<title>. They now check the label'saria-label(which names the kind), that the row has exactly one<svg>, and that pull requests and issues get differentdata-iconvalues.Test plan
pnpm --filter ./apps/web exec vitest run: 1250 passedastro check: 0 errorsoxlintandoxfmtclean on the changed files