remove BOOST_ASSERT from two-graph-common-spanning-trees - #610
Merged
Becheler merged 4 commits intoSep 28, 2026
Conversation
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in): No header-inclusion-weight changes. Transitive Boost modules: 47 → 47 (0) |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
Compiler-warning counts vs
|
Contributor
|
@andreacassioli I think the fix in #609 would clear the failure here. |
Collaborator
|
Yes, if @andreacassioli could give it a try by rebasing on develop that would be awesome ! |
andreacassioli
marked this pull request as ready for review
September 27, 2026 18:26
andreacassioli
requested review from
Becheler and
jeremy-murphy
as code owners
September 27, 2026 18:26
…ASSERTION-two-graph-common-spanning-trees
Becheler
requested changes
Sep 28, 2026
Becheler
approved these changes
Sep 28, 2026
Becheler
left a comment
Collaborator
There was a problem hiding this comment.
thank you @andreacassioli for the changes !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
Drop the use of BOOST_STATIC_ASSERT, use static_assert
Drop the use of boost::is_same, use std::is_same
Motivation
Part of #593, tier 2 section 2.1
Testing
Manual testing
Checklist
b2in thetest/directory).