Skip to content

remove BOOST_ASSERT from two-graph-common-spanning-trees - #610

Merged
Becheler merged 4 commits into
boostorg:developfrom
andreacassioli:drop-BOOST_STATIC_ASSERTION-two-graph-common-spanning-trees
Sep 28, 2026
Merged

Becheler merged 4 commits into
boostorg:developfrom
andreacassioli:drop-BOOST_STATIC_ASSERTION-two-graph-common-spanning-trees

Conversation

@andreacassioli

@andreacassioli andreacassioli commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Before submitting

  • This PR targets the develop branch.
  • I searched for an existing PR or issue covering the same change.
  • My contribution is licensed under the Boost Software License 1.0.

Type of change

  • Bug fix
  • New feature or API addition
  • Refactor (no behavior change)
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

Does this PR introduce a breaking change?

  • Yes (describe migration impact below)
  • No

What this PR does

Drop the use of BOOST_STATIC_ASSERT, use static_assert
Drop the use of boost::is_same, use std::is_same

Motivation
Part of #593, tier 2 section 2.1

Testing

Manual testing

Checklist

  • Existing tests pass (b2 in the test/ directory).
  • New behavior is covered by a test, or this is a docs / build / refactor change.
  • Documentation was updated if user-facing behavior changed.
  • No new compiler warnings on the platforms I built against.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 36444399762 vs develop run 36395676983 (79b93a5444).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 47 → 47 (0)

@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 36444399797 vs develop run 36395677010 (79b93a5444).

Job Baseline After Delta
macos (clang, 14) 392 392 0
macos (clang, 17) 391 391 0
macos (clang, 20) 391 391 0
ubuntu (clang-19, 14) 392 392 0
ubuntu (clang-19, 17) 391 391 0
ubuntu (clang-19, 20) 391 391 0
ubuntu (clang-19, 23) 391 391 0
ubuntu (gcc-14, 14) 345 345 0
ubuntu (gcc-14, 17) 341 341 0
ubuntu (gcc-14, 20) 341 341 0
ubuntu (gcc-14, 23) 341 341 0
windows_msvc_14_3 (msvc-14.3) 931 931 0

@reach2sayan

Copy link
Copy Markdown
Contributor

@andreacassioli I think the fix in #609 would clear the failure here.

@Becheler

Copy link
Copy Markdown
Collaborator

Yes, if @andreacassioli could give it a try by rebasing on develop that would be awesome !
thanks to you both <3

@andreacassioli andreacassioli changed the title remove BOOST_ASSERT remove BOOST_ASSERT from two-graph-common-spanning-trees Sep 27, 2026
@andreacassioli
andreacassioli marked this pull request as ready for review September 27, 2026 18:26
Comment thread include/boost/graph/two_graphs_common_spanning_trees.hpp Outdated
@Becheler Becheler added beginner friendly technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing. labels Sep 28, 2026

@Becheler Becheler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @andreacassioli for the changes !

@Becheler
Becheler merged commit e50c95a into boostorg:develop Sep 28, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginner friendly technical debt Code that works but needs refactoring, cleanup, or modernization. Not user-facing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants