Skip to content

fix: ignore inline shell commands in agent detection - #38

Merged
alecthomas merged 2 commits into
block:mainfrom
jrobotham-square:jrobotham/fix-shell-agent-detection
Oct 6, 2026
Merged

alecthomas merged 2 commits into
block:mainfrom
jrobotham-square:jrobotham/fix-shell-agent-detection

Conversation

@jrobotham-square

@jrobotham-square jrobotham-square commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Shell command text such as git commit -m 'deploy goose-example' can cause a Bash process to be attributed to Goose before its Codex parent is considered. Skip inline command arguments for common shells while preserving detection from agent executables and interpreter script paths.

The manual reproduction now credits Codex. Includes regression coverage and the equivalent ? expression in Git-root lookup required by the current Clippy version.

Generated with Codex

Co-authored-by: Codex <noreply@openai.com>
@jrobotham-square
jrobotham-square force-pushed the jrobotham/fix-shell-agent-detection branch from b087e80 to 8474b45 Compare October 6, 2026 06:26
Co-authored-by: Codex <noreply@openai.com>
@jrobotham-square
jrobotham-square marked this pull request as ready for review October 6, 2026 09:45
@alecthomas
alecthomas merged commit c0ca9ae into block:main Oct 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants