Repository navigation
Fix participants.tsv parsing when metadata contains spaces - #86
Merged
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: 919761f7-17f2-4c94-919f-b72bb5fe748c) |
bbuchsbaum
marked this pull request as ready for review
October 29, 2026 20:15
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: e5337d15-42fa-463b-a77d-8d9aca6120b4) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bids_project()splits participant metadata on arbitrary whitespace, so valid values such ashomo sapienscan cause “more columns than column names”. Specifysep = "\t"in the participant reader to preserve spaces within TSV fields.Adds an integration regression test that opens a minimal dataset with multiword species and group values and verifies the exact metadata, participant ID, column names, row count, and numeric age.
Validation: reviewed the change against the current reader and existing test fixture. R/Rscript is not installed in the editing environment, so the test suite and R CMD check have not been run locally; this draft awaits GitHub CI validation.
Fixes #84.
Note
Low Risk
Single-line parsing change in participant metadata loading with a targeted regression test; no auth or security impact.
Overview
Fixes
bids_project()failing on validparticipants.tsvrows when metadata values contain spaces (e.g.homo sapiens,healthy control). The loader now passessep = "\t"toread.table()in.bidser_load_participants_df, so columns split only on tabs instead of arbitrary whitespace.Adds a regression test that overwrites
participants.tsvwith multi-wordspecies/groupfields and checkspart_dfcolumn names, string values, row count, and numericage.Addresses #84.
Reviewed by Cursor Bugbot for commit 4bc3749. Bugbot is set up for automated code reviews on this repo. Configure here.