Repository navigation
ci: adapt the Android writer_lock.rs patch to the codex 0.166.0 try_lock loop - #241
Merged
Merged
Conversation
…ock loop Keep the 0.165.0 pattern and add the 0.166.0 one; treat mixed or duplicated patterns as errors. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream codex 0.166.0 replaced the blocking
file.lock()inlock_coordination()with a 30-secondtry_lock()retry loop, so the Android writer_lock.rs patch no longer matched and the build stopped at "Apply Android build patches".This keeps the existing 0.165.0 pattern and adds the 0.166.0 one. On Android the new loop calls the existing
android_try_flock_exclusivehelper (std returnsUnsupportedthere); the non-Android loop is kept verbatim. The state check now fails on mixed, duplicated or partially applied patterns instead of silently skipping them.Only the inline Python of the writer_lock.rs step in
external-build-android-aarch64.ymlchanges.🤖 Generated with Claude Code