Skip to content

Fixed: nextdns_sync copies Main's whole settings block #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bakerboy448 merged 1 commit into from
Oct 19, 2026
+8 −24
Merged

Fixed: nextdns_sync copies Main's whole settings block #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions nextdns_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,6 @@
# Rewrites that are site-specific (Main only), not synced to other profiles
SITE_SPECIFIC_REWRITES = os.getenv("NEXTDNS_SITE_SPECIFIC_REWRITES", "").split(",")

# Settings to enforce across all synced profiles
SETTINGS_SYNC = {
"bav": True,
}
SETTINGS_PERFORMANCE_SYNC = {
"cnameFlattening": False,
"ecs": True,
"cacheBoost": True,
}
SETTINGS_LOGS_SYNC = {
"retention": 604800, # 7 days
}

# Record that must resolve to a CGNAT (Tailscale) address on every profile after sync
TAILNET_CHECK_NAME = "tail-home.bakerflix.app"
TAILNET_CHECK_NET = ipaddress.ip_network("100.64.0.0/10")
Expand Down Expand Up @@ -331,19 +318,16 @@ def sync_rewrites(source_id: str, target_ids: List[str]) -> None:


def sync_settings(target_ids: List[str]) -> None:
"""Syncs settings (bav, performance, logs) to target profiles."""
"""Copies Main's whole settings block (logs, blockPage, performance, web3, bav)."""
settings = fetch_profile_settings(PROFILE_MAIN)["data"].get("settings", {})
scalars = {k: v for k, v in settings.items() if not isinstance(v, dict)}
for target_id in target_ids:
if target_id is None:
continue
try:
if SETTINGS_SYNC:
update_profile_settings(target_id, SETTINGS_SYNC, "settings")
if SETTINGS_PERFORMANCE_SYNC:
update_profile_settings(
target_id, SETTINGS_PERFORMANCE_SYNC, "settings/performance"
)
if SETTINGS_LOGS_SYNC:
update_profile_settings(target_id, SETTINGS_LOGS_SYNC, "settings/logs")
if scalars:
update_profile_settings(target_id, scalars, "settings")
for key, value in settings.items():
if isinstance(value, dict):
update_profile_settings(target_id, value, f"settings/{key}")
logger.info("[SETTINGS-SYNC] Updated settings for %s", target_id)
except Exception as e:
logger.error("[SETTINGS-SYNC] Failed for %s: %s", target_id, e)
Expand Down
Loading