Repository navigation
Fixed: nextdns_sync prunes stale parentalControl services, exits nonzero on errors - #16
Merged
Merged
Conversation
…onzero on errors PATCH on parentalControl never removes services and timed out at 10s, and errors were swallowed (exit 0). Raise that timeout to 30s, delete target services Main lacks via DELETE /profiles/<id>/parentalControl/services/<id>, and exit 1 if any error was logged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parentalControl PATCH never removes services and timed out at 10s on RPM every run; errors were swallowed (exit 0).
/profiles/<id>/parentalControl/services/<id>)Script(s) affected
Tested live: diff + sync via the timer command, exit 0, parentalControl IN SYNC. No secrets in diff.
🤖 Generated with Claude Code