Repository navigation
feature(sdk-core): send saved reports with their breadcrumbs on the first retry - #412
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reports saved during a crash or while offline now go out on the next launch with their breadcrumbs, instead of failing once and arriving a minute later without them.
Changes
SessionFiles.ts: return the session matching the given id fromgetSessionWithId, not the current one.BacktraceDatabase.ts: skip the session lock for reports from the current session.BacktraceClient.ts(node): keep a replayed crash's breadcrumbs until its report is sent.SessionFiles.spec.ts: covergetSessionWithIdfor the current, previous, older and unknown sessions.databaseSessionFilesTests.spec.ts: new, cover a saved report keeping its breadcrumbs through the first upload and after a failed send, reports from the current session.crashReplayTests.spec.ts: new, cover a node crash report keeping its breadcrumbs after a failed send.Note
Needs
@backtrace/nodereleased with the next sdk-core version.ref: BT-7462